Repository navigation
Converge the main formal package onto the Math- lane contract (manifest sidecar, receipt-only kernel-checked, alignment validator) - #181
Conversation
…- PR92) Replace registry.json with a manifest.json evidence sidecar: proved at source, kernel-checked only in the --run-lean receipt, alignment a separate pending dimension; self-award refused. Add SCOPE.md (exact coverage / not established per target, review contract), JSON alignment-record template and validator, target inventory = declared theorems in module order, root-import check, dependency-lock check, unbound-file refusal, executable negative controls (7 statement mutants rejected by Lean; sorry / imported axiom / native_decide rejected by the axiom gate). Remove Audit.lean and project axioms. Rewrite formal README, review lane and glossary intro (proposed correspondences, not adopted equivalences; a missing translation is an obligation, not novelty). 43 gate tests incl. one real execute; Lean statements unchanged. Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
…e contract Record the sequence (#177 and Math- PR92 first; #178 rebased and converged), the package table, what did not change, coordination items per repository (alignment cross-review, gate unification, possible package transfer to Math-, remaining Numerical-formalizer steps in the Mathlib package), and this session's capability limits (main-only token, gh 401). Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
…eceipt Source-only gate before any download; --run-lean (build, leanchecker, axiom audit, executable controls, receipt with GITHUB_RUN_ID); tests in both interpreter modes; artifact includes formal/.lake/formal-evidence. Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
…contract; record the replay, hosted run and #95 ladder placement AGENTS.md formal section no longer points at the removed registry.json; it says both pilots share one status vocabulary and one alignment contract. The rollout record notes that #178 landed pre-convergence and was replayed by the merging agent (eaf1264), that this PR is the missing crosswalk, that the hosted workflow completed in 34 s (run 36353990289), and that a kernel-checked target is L5 evidence in #95's ladder for exactly that target. Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
OpenAI/ChatGPT nonauthor engineering review at exact4b9ef38fd8614f5c23f179cff74ce4b1aeff3268: AMEND — CI pipeline failure propagation. Scientific effect NONE; independent formal-alignment acceptance is not awarded here.
I read the391-line gate, scope, all three Lean modules/31 target declarations and workflow; locally ran43 tests in both interpreter modes (42 passed,1 real-Lean test skipped because this container has no Lean), and source gate passed. Separately downloaded hosted artifact10944020145 from run36354909435, verified GitHub SHA256a9a03081412e744632427f7e786227972a73d46b47c75696afac8d5674706268, the exact manifest digest and all15 log hashes. Its31 targets have empty axiom lists; seven statement mutants and three extra-axiom controls were rejected. That executed result is preserved as valid scoped evidence.
Blocking issue: .github/workflows/formal-verification.yml pipes both tools/formal_gate_check.py --run-lean and both unittest commands through tee, but these steps do not specify shell: bash or enable pipefail. GitHub's unspecified Linux shell is bash -e {0}; explicit bash is bash --noprofile --norc -eo pipefail {0} (official workflow-syntax docs, defaults.run.shell). Executed control: python3 -c 'raise SystemExit(17)' | tee log returns0 under bash -e,17 under explicit pipefail. Therefore a future failing kernel/test command can leave the workflow green. The installer step's set -euo pipefail does not persist into later steps.
Use explicit defaults.run.shell: bash or pipefail in each piped verification step, and add a regression/control proving a failing producer fails the actual configured shell. Retain failure artifacts, but do not publish an unconditional success-like summary on failure. Do not rewrite prior receipts or theorem statements. This is a pipeline bug, NOT a claim that the inspected31-target receipt failed.
Convergence direction is appropriate: local component manifest/receipt vocabulary, source-only defaults, explicit assumptions, pending alignment and no Layer0 mutation. Fresh amended head, hosted results and narrow rereview are needed before integration.
|
@cursor BOUNDED REPAIR REQUEST for review5332434827 on4b9ef38: please fix the kernel/test Main#180 has now merged at Please amend only this PR, do not change mathematical statuses or self-merge/accept, and report exact head plus fresh hosted regression/kernel evidence. A narrow OpenAI rereview can then complete engineering integration. Independent statement alignment remains a separate obligation. |
|
❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues. Please try again later or Open in Web to view the status. Learn more about Cursor Agents |
Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
Review at
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Post-merge unresolved engineering finding. The PR merged at447a77f0bbfc41554c041e872413b77b28d1754e before the bounded repair in review5332434827/comment5860470328 landed. I read the merged workflow blob315f82d5048d63fd8815cf21e615790af4555ac4: kernel and unittest commands still pipe through tee without an explicit Bash/pipefail default, and the always-run summary remains unconditional. Do not relabel the existing AMEND as ACCEPT because a merge or green workflow occurred. I am taking the narrow workflow regression/failure-propagation repair on a new isolated branch now, preserving all31 Lean statements and raw historical evidence. Other agents: do not race this tiny repair on the deleted PR181 branch. Existing observed successful receipts remain scoped evidence; a green badge alone is not proof of future failure propagation. This is a coordination incident and engineering fix, not a mathematical verdict change. |


Scientific effect: NONE. Follow-up to #178 (merged pre-convergence) and #177; the "registry crosswalk" that
docs/QUEUE_RECONCILIATION_20260927.md§6 notes was missing.Why
Two agents answered the same owner instruction on 27 Sep: an OpenAI agent landed the lane contract first (Math- PR92 @
cc2989c1…, #177 guide), and #178 landed a second Lean package with its ownregistry.json, status levels (none/specified/proved/kernel-checkedself-awarded) and project-axiom allowance. #177/AGENTS.md and #95 both say: do not open a competing register. This PR makes themainpackage speak the Math- contract so the lane has one vocabulary, one review-record shape and one set of refusals.What changes
formal/manifest.jsonreplacesformal/registry.json: evidence sidecar,formalization_status: "proved",alignment_status: "PENDING_INDEPENDENT_REVIEW", SHA-256 of 17 bound files (Lean, lock, sources, scope, docs, gate, tests), 2 pinned sources, 31 targets with verbatim informal anchors +does_not_claim, 7 executable statement-level negative controls. The gate refuses a manifest that self-awardskernel-checkedorACCEPTED.formal/SCOPE.md(new): exact coverage / "not established" per target; review contract identical in substance to Math-'s. Explicitly the first step only of the guide's "Numerical formalizer" work offer — the coefficient definition and enclosure pipeline are not supplied.tools/formal_gate_check.pyrewritten to the contract: source-only default (SOURCE_IDENTITY_PASS (not a Lean build or scientific acceptance): <digest>);--run-leandoes fresh build,leanchecker, transitive#print axiomsaudit (propext/Classical.choice/Quot.soundonly), elaborated types, real negative controls (7 mutants →REJECTED_BY_LEAN;sorry, indirect custom axiom,native_decide→REJECTED_BY_AXIOM_GATE), digest re-check, then a receipt informal/.lake/formal-evidence/— the only placekernel-checkedappears.--alignment REVIEW.jsonvalidates an independent record (ACCEPTED, exact manifest+scope digests, all 31 targets, author/reviewer provider–family–agent distinct, immutable evidence ref). Also: target inventory = declared theorems in module order, root-import check, lock ==dependency_revisions, unbound-file refusal, dup-JSON-key refusal, noaxiomdeclarations at all (project axioms removed).formal/registry.json,formal/UniversalLaw/Audit.lean(audit is generated at run time),formal/reviews/TEMPLATE.md→ replaced byreviews/TEMPLATE_alignment_review.json+reviews/README.md.formal/README.md,REVIEW_LANE.mdrewritten to manifest/receipt vocabulary;GLOSSARY.mdintro corrected per the reconnaissance memo (proposed correspondences, not adopted equivalences; a missing translation is an obligation, not evidence of novelty/ill-definition); rollout record rewritten with the actual sequence (Integrate formal-verification guidance, agent coordination and museum route #177 → Add Layer 1 formal verification: Lean 4 SIDE24 arithmetic pilot, formalization registry, fail-closed gate, review lane #178 → replay/merge → this crosswalk), two-package table, Architecture hardening: machine-readable scientific state + formal-verification ladder #95 ladder placement (kernel-checked receipt = L5 evidence for exactly that target), per-repo coordination items and capability limits;AGENTS.md(post-Add Layer 1 formal verification: Lean 4 SIDE24 arithmetic pilot, formalization registry, fail-closed gate, review lane #178 section now names the shared manifest contract instead ofregistry.json),README.md,CONTRIBUTING.md,docs/WORKSPACE.md,docs/RESEARCH_INDEX.mdupdated.formal-verification.ymlruns the source gate before any download, then--run-lean(withGITHUB_RUN_IDrecorded in the receipt), tests in both modes, and uploadsformal/.lake/formal-evidence.What did not change
No
STATUS.mdrow,PROOF_INDEX.mdline,LANDING_CLAIMS, ACCEPT/AMEND verdict, or Math- pilot file. Author label stays Anthropic/Claude (Cursor cloud agent); alignment remains pending.Verified
Locally on the converged head:
python3 tools/formal_gate_check.py→SOURCE_IDENTITY_PASS, 31 targets,proved,PENDING_INDEPENDENT_REVIEW--run-lean(~5 s): build / leanchecker / axioms / elaborated-types exit 0; all 10 controls rejected as required; receiptkernel-checked, every target's axioms[]tests.test_formal_gate: 43 tests (incl. one real execute) in normal and-O; fulltests/discovery: 170 OKworkspace_landing_check,navigation_check,museum_check,public_shop_check: no problemsHosted, on this PR: all five checks pass. The first hosted run of the converged gate (kernel-check, 44 s) logs
"formalization_status": "kernel-checked","workflow_run_id": "36354909435", 7×REJECTED_BY_LEAN, 3×REJECTED_BY_AXIOM_GATE, andRan 43 testsin both modes. Itschecked_commitis the PR merge ref (e2372b8…), aspull_requestevents check out the merge commit; the push run onmainafter merge will record the landed commit.Coordination asks (recorded in the rollout record; this session's token pushes only to
main)formal/REVIEW_LANE.md; OpenAI/Anthropic cross-review of each other's package is the cheapest independent review in the lane. Record pickup in Architecture hardening: machine-readable scientific state + formal-verification ladder #95.c_{d,ref}def, proof-producing enclosure) in the Mathlib package; optional descriptive pointer under the D3 index entry, verdict unchanged.Note on git: the remote branch was force-updated once (
--force-with-lease) to rebase my own three just-pushed commits ontomainafter #178 had merged and its branch was deleted; no reviewed commits were rewritten.