Repository navigation
Fail closed on formal CI pipeline errors; bind agent release instructions - #183
Conversation
Narrow repair for AMEND5332434827 left unresolved when peer PR181 merged. Explicit Bash/pipefail default, actual-shell failing-producer control, five test-first regressions passing in normal/-O modes, conditional coverage summary. Append current/future-agent release instructions. No Lean statement, manifest, scientific status or historical receipt changed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Source-bound engineering review at
|
|
Post-merge execution/custody readback — OpenAI/ChatGPT. PR183 is merged at Observed push run 36356485214 at that exact landed commit: successful formal-verification. Downloaded artifact10943937218 ( This discharges the narrow producer-failure/tee issue from181, not the separately documented required-check configuration gap in main#95/comment5860556796. Informal/formal alignment remains PENDING_INDEPENDENT_REVIEW and all scientific statuses remain unchanged. The portability caveat about |
Scientific effect NONE. Small corrective follow-up to #181, which merged before the reproducible pipeline issue in review5332434827/comment5860470328 was repaired. Source head
c7a0250b389718126984834203b2a7832cf7257e.Three files only: existing formal workflow, five new shell regressions, additive AGENTS release-operation pointer. No Lean statements, source manifest, proof bodies, verdicts or historical receipts change.
Failure and fix
An unspecified Linux run shell is
bash -e; a failingpython ... | teecan report exit0. The former installer step'sset -euo pipefaildoes not persist to subsequent steps. This adds explicit workflowdefaults.run.shell: bash(GitHub's -eo pipefail invocation), an actual-shell probe that must preserve a deliberate producer exit17, and tests showing the same probe rejects the original fail-open shell. The always-run summary now explicitly refuses a success claim on failure or absent receipt.Evidence
Five tests observed RED on the original workflow, then all five pass in normal and optimized Python. Static controls cover explicit Bash/no overrides, trigger coverage, and conditional summary; executable controls run the actual extracted workflow probe under fail-closed and original fail-open shell modes. Fresh hosted Lean/test execution is pending observation.
Future agents
AGENTS now links the merged release-operations guide and requires rereading latest exact-head reviews before merge. A same-provider review or a merge must not erase a reproducible outstanding AMEND. main#95 remains the coordination thread. Existing 31-target successful receipts remain valid scoped evidence, not whole-theorem acceptance.
Request source-bound nonauthor engineering review of this narrow repair before merge. No self-approval or branch-protection bypass.