docs(ship): define orchestrator-composed ship units - #2156
Conversation
There was a problem hiding this comment.
Changes requested: The record’s boundary section cites the wrong decision for the one-thread-per-unit rule.
Warning
Changes requested · head e43f3b7 · 1 finding: 1 minor
| Severity | Finding | Where |
|---|---|---|
| minor | F1 Boundary attributes one-thread-per-unit to the wrong record | docs/decisions/0073-the-ship-pipeline-dissolves-into-the-orchestrator-the-unit-machine-is-the-deterministic-atom-and-judgement-composes-units.md:130 |
Full review
F1 — Record 0056 governs dashboard navigation, not one-thread-per-unit. That rule belongs to record 0055, which this record correctly cites at line 15. Change the boundary reference to 0055 so readers reach the authoritative decision.
|
Cold-reader receipt for record 0073 (the acceptance gate). Run 2026-09-21 19:47Z by the maintainer's operator session: a fresh agent session that was handed only the record as it stands at
This is the independent receipt the record's cold-reader gate asks for. The acceptance ask that follows this PR carries it into a dated amendment note; this PR stays |
e43f3b7 to
c9e82a6
Compare
There was a problem hiding this comment.
LGTM: The prior attribution finding is fixed, and no findings remain at the current head.
Note
Approved · head c9e82a6 · no findings
Full review
F1 is resolved: the boundary now correctly attributes one-thread-per-unit to record 0055. No findings remain.
Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
c9e82a6 to
5e3f14e
Compare
There was a problem hiding this comment.
LGTM: The rebase resolves the old-head consistency failures, and no findings remain in the full change.
Note
Approved · head 5e3f14e · no findings
Full review
The rebase updates the record and generated index consistently with record 0072’s accepted status. No findings remain.
Adds proposed record 0073: the guarded ship unit stays deterministic while an LLM orchestrator chooses each bounded act from fresh facts. The generated index now uses public vocabulary so the consistency gate can pass.
Why: The failed consistency check exposed the internal “runner” noun after F1’s record correction. Recovery failures in #2134, #2154, and #2153 need one authoritative boundary.
Where to look
Feedback wanted: Judge whether the atom/composer boundary is mechanically enforceable and whether each conflict, question, re-issue, and rolled parent has one truthful next state.
Risk: Docs-only proposal. A wrong boundary could direct implementation toward dual ownership or model-controlled guards; rollback is reverting the record and generated index before acceptance.
Verified: Local gates pass; CI bot, workers, image, docs, web, and package checks pass. CodeQL and the independent cold-reader gate remain pending.
Decisions (3)
Validation (6 criteria)
ci / botandci / bot / check:consistencycompleted successfully at pushed head 5e3f14e.npm run check:consistencypassed at rebased head 5e3f14e, including docs, decisions, hygiene, specs, and vocabulary checks.npx prettier --check <record> docs/explanation/design-decisions.mdpassed after the final rebase.npm run check:pr-title -- "docs(ship): define orchestrator-composed ship units"passed.git diff --check origin/main...HEADpassed at pushed head 5e3f14e.For agents
Rebased onto
origin/mainat4bcc7f07; the generated index conflict was resolved by rerunningnpm run docs:gen, not hand-editing. Main accepted record 0072 during the rebase, so record 0073 now distinguishes accepted authority from unimplemented state. F1 remains fixed at lines 15 and 130 through record 0055. The single coherent commit is5e3f14e0; no tests or TypeScript checks apply because only Markdown changed.Requested by @justinhelmer in slack:C0BRRHKFLCB
🤖 Generated with Claude Code