docs(ship): accept orchestrator-composed ship units - #2162
Merged
Merged
Conversation
coreplane-switchboard
Bot
requested a review
from justinhelmer
as a code owner
September 21, 2026 20:19
Contributor
Author
There was a problem hiding this comment.
LGTM: The acceptance amendments and three-unit plan satisfy the decision's gates and preserve the existing machine and merge-door guards.
Note
Approved · head 758b77a · no findings
Full review
No findings. The acceptance amendments and implementation plan satisfy the unit contract without weakening existing guards.
Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
coreplane-switchboard
Bot
force-pushed
the
plan/take-decision-record-007-f0f491/u1
branch
from
September 21, 2026 20:32
758b77a to
584e6e4
Compare
Contributor
Author
There was a problem hiding this comment.
LGTM: The receipt-link fix is valid, and both prior CI findings are resolved at the current head.
Note
Approved · head 584e6e4 · no findings
Full review
No findings. The receipt link is valid, and both previously failing CI checks now pass at the reviewed head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts decision record 0073 with its independent reader receipt and a tree-backed correctness amendment. Adds a three-unit plan that can replace the plan runner without losing work, duplicating ownership, or weakening unit and merge guards.
Why: The acceptance request supplied the independent receipt, but record 0073 still needed a total, rollback-safe implementation contract over record 0072.
Where to look
Feedback wanted: Please judge the composer-transfer boundary during a mid-round flag flip and whether the eight-class reconcile projection is complete without softening a unit-machine guard.
Risk: Documentation only; incorrect requirements could guide a later unsafe ownership migration. Roll back by reverting the commit and leaving record 0073 proposed. No runtime or deploy change.
Verified: Focused links test and all scoped gates pass; full CI is green at 584e6e4. The post-merge main-file receipt remains human-gated.
Decisions (3)
Validation (10 criteria)
npx vitest run src/docs/links.test.ts— PASS, 1 file and 7 tests at rebased head 584e6e4.npx prettier --check <3 changed Markdown files>— PASS after rebase.npm run hygiene:check— PASS; 9 files and 37 listed hits remain, 138 lines allowed.npm run specs:check— PASS; 51 specs and 5656 proof references checked.npm run decisions:check— PASS; 112 records valid against merge-base 2d6dd17.npm run docs:check— PASS; all 12 generated files match.npm run check:pr-title -- "docs(ship): accept orchestrator-composed ship units"— PASS.For agents
Rebased onto origin/main at 2d6dd17 and force-pushed coherent head 584e6e4. The failed CI shard was reproduced until
src/docs/links.test.tsidentified the repository-external relative link; that diagnostic shard command timed out after exposing the failure, so the full shard is not claimed locally. The focused links suite passes 7/7, and hosted shard 2 plus the aggregate bot gate are green. The receipt now links the exact public GitHub API comment URL by immutable repository and comment ids, preserving the public-hygiene baseline.docs/explanation/design-decisions.mdis generated.Requested by @justinhelmer in slack:C0BRRHKFLCB
🤖 Generated with Claude Code