fix: resolve #696 withdraw threshold reminders, #694 onboarding skip/progress, #693 skeleton shimmer, #692 transaction filters - #704
Merged
Conversation
…it-protocol#694 onboarding skip/progress, conduit-protocol#693 skeleton shimmer, conduit-protocol#692 transaction status filters
|
@0xSlink Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four UI/UX issues in one PR:
lib/withdraw-config.ts: configurable auto-withdraw threshold reminders with localStorage persistence (getAutoWithdrawThreshold/setAutoWithdrawThreshold, envNEXT_PUBLIC_AUTO_WITHDRAW_THRESHOLD, default 100) plus browser Notification API integration (isNotificationSupported,requestThresholdNotificationPermission,notifyWithdrawThresholdReached,checkAndNotifyWithdrawThreshold,hasReachedWithdrawThreshold).components/OnboardingTour: visible quick-skip option plus step progress. Adds a 'Skip Tour' link in the modal header (via new optionalModal.headerAction) witharia-label="Skip tour", keeps the footer Skip/Back/Next actions, and renders step dots withrole="progressbar"+Step X of Ncounter.components/stream/StreamCardSkeleton: shimmer pulse animation. Addsskeleton-shimmerlinear-gradient sweep keyframes inapp/globals.css(with dark-mode + reduced-motion handling) and applies it to all skeleton placeholder elements alongside existinganimate-pulse.app/transactions/page.tsx: status filter tabs (All, Confirmed, Pending, Failed) with counts that filter the transaction table client-side viamatchesStatusFilter(Confirmed maps Success, Failed covers Failed/Reverted alias). Export CSV uses the filtered rows; empty-filter state shows per-tab message.Testing
Per task instructions, tests were not run and no installations were made; changes follow existing component patterns and preserve prior exports/behavior.
Closes
Closes #696
Closes #694
Closes #693
Closes #692