Repository navigation
Conversation
This was referenced Aug 16, 2026
Contributor
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
irvinebroque
marked this pull request as ready for review
September 2, 2026 18:59
irvinebroque
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne and
vy-ton
as code owners
September 2, 2026 18:59
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32550 (https://github.com/cloudflare/cloudflare-docs/pull/32550).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-39302a5c0ac8 · Contradictory specifier resolution claims
- **File:** `src/content/docs/workers/reference/module-registry.mdx` line 70
- **Issue:** The example states `import.meta.resolve("fs")` returns `"node:fs"`, but the section "Specifiers are URLs" (line 79) says specifiers are resolved via `new URL(specifier, base)` uniformly — and `new URL('fs', 'file:///bundle/index.js')` yields `file:///bundle/fs`, not `node:fs`. The two statements contradict each other, so a reader cannot tell whether bare builtin names are special-cased or whether the example is wrong.
- **Fix:** Clarify that bare specifiers matching Node builtin names are mapped to `node:` URLs (if that is the intended behavior), or change the example to use a `node:`-prefixed specifier such as `import.meta.resolve("node:fs")`.
---
## Style Guide Review
### Warnings (3)
#### SG-3185b51e4c5b · Use <TypeScriptExample> instead of raw js/ts fences in docs MDX
- **File:** `src/content/docs/workers/reference/module-registry.mdx` line 243
- **Issue:** Line adds a raw ```js fenced block in a docs MDX file
- **Fix:** Replace the raw ```js fence with <TypeScriptExample> and write the example in TypeScript
#### SG-4698fdb294ec · Use TypeScriptExample for JS/TS code blocks in docs MDX
- **File:** `src/content/docs/workers/runtime-apis/webassembly/javascript.mdx` line 93
- **Issue:** Added line opens a raw ```js fenced block in a src/content/docs/ MDX file
- **Fix:** Use the <TypeScriptExample> component instead, which auto-generates a JS tab from the TypeScript source.
#### SG-16600f363caa · Use TypeScriptExample for JS/TS code blocks in docs MDX
- **File:** `src/content/docs/workers/runtime-apis/webassembly/javascript.mdx` line 101
- **Issue:** Added line opens a second raw ```js fenced block in a src/content/docs/ MDX file
- **Fix:** Use the <TypeScriptExample> component instead, which auto-generates a JS tab from the TypeScript source.
### Suggestions (1)
#### SG-3578aac5ee8b · Bullet list with fewer than three items
- **File:** `src/content/changelog/workers/2026-08-05-new-module-registry.mdx` line 22
- **Issue:** The `## Performance improvements` section contains only two bullet items (lines 22 and 23).
- **Fix:** Consider writing the two items as prose instead of a bullet list.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewWarnings (3)
Suggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
irvinebroque
approved these changes
Sep 2, 2026
irvinebroque
force-pushed
the
jasnell/new-module-registry
branch
from
September 4, 2026 20:40
7775fd5 to
fc04765
Compare
neelakolkar-cf
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation for the workers new module registry.
Just in preparation... not yet ready to merge
Documentation checklist