Remove deprecated macos deps - #18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecc26cfaa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| end | ||
|
|
||
| depends_on :macos => :ventura | ||
| depends_on macos: :ventura |
There was a problem hiding this comment.
The replacement is not equivalent to the deleted bare depends_on :macos: Homebrew treats a versioned macOS requirement as a macOS version floor and it is satisfied on Linux, so Linuxbrew can now reach this formula's unconditional tarball and install block and create a wrapper to tart.app/Contents/MacOS/tart instead of rejecting a Linux install. This affects Linux users installing tart; keep an explicit macOS-only gate in addition to the Ventura floor.
Useful? React with 👍 / 👎.
| homepage "https://github.com/cirruslabs/softnet" | ||
| version "0.19.0" | ||
| depends_on :macos | ||
|
|
There was a problem hiding this comment.
The removed line here was the only macOS-only gate; the remaining depends_on :macos => :sequoia is just a versioned macOS requirement and is considered satisfied on Linux, so Linuxbrew can now install the Sequoia-only softnet.tar.gz instead of rejecting the formula. This affects direct Linux installs of softnet and dependency installs through tart.
Useful? React with 👍 / 👎.
Restrict formula installation to supported macOS environments and explicitly guard against unsupported platforms. Kept dependency resolution predictable.
|
Similar to the other PR I commented on: The files changed in this PR have "DO NOT EDIT" markers in them: I think the fixes need to go in the upstream repos. |
2 participants
Replace deprecated
depends_on :macosdeclarations.mtell.rbandgitlab-tart-executor.rbrelied ondepends_on :macosto prevent Linuxbrew from selectingDarwin artifacts on matching CPU architectures.
These formulae are now explicitly wrapped in
on_macosblocks while preserving existing behavior.
tart.rbwas updated to current Homebrew syntax formacOS version constraints.