Fix deprecated depends_on :macos usage in tart and softnet formulas - #19
Closed
alokdhir wants to merge 1 commit into
Closed
Fix deprecated depends_on :macos usage in tart and softnet formulas#19alokdhir wants to merge 1 commit into
alokdhir wants to merge 1 commit into
Conversation
Homebrew deprecated passing a minimum OS version directly to depends_on :macos outside of an on_macos block, which produces a warning on every brew command. Wrap the version-specific dependency in an on_macos block in both formulas to silence the warning.
Author
|
Closing as duplicate of #16 and #18. Confirmed the actual fix already exists upstream: both |
|
@alokdhir thanks that makes sense, I was about to do the same PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brew install cirruslabs/cli/tartcurrently prints this warning:The formula sets a minimum macOS version via
depends_on :macos => :venturaoutside of an
on_macosblock, which Homebrew now considers deprecatedsyntax.
softnet.rb(a dependency oftart) has the same issue withdepends_on :macos => :sequoia.Fix
Wrap the version-specific
depends_on :macoscall in anon_macosblock inboth
tart.rbandsoftnet.rb, matching the syntax Homebrew expects.Note: these formulas are marked "generated by GoReleaser, DO NOT EDIT", but
the upstream
tartrepository has moved toopenai/tartand now publishesto a different tap, so this tap is no longer auto-updated for
tart/softnetreleases. This same fix has already been applied upstream in the newer
.goreleaser.yml, so this PR just brings it here directly.