Repository navigation
feat(spectre): read CFG_CHAIN_RPC_URLS from a Secret [sc-22327] - #338
Merged
Merged
Conversation
Add rpcUrlSecret {name, key}. When name is set, CFG_CHAIN_RPC_URLS comes
from valueFrom.secretKeyRef and rpcUrl is ignored, so an RPC URL that
carries an API key can stay out of plain Helm values. A name without a
key fails the render. With the value unset the render is unchanged apart
from the chart label, so current releases see no pod change.
ci/secret-rpc-values.yaml installs the relay with an empty rpcUrl and the
URL in a Secret, so ct install fails if the Secret path breaks.
Bump spectre to 0.3.10.
paulohpigatto
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spectre renders
CFG_CHAIN_RPC_URLSfrom the plainrpcUrlvalue, so an RPC URL that carries an API key has to sit in Helm values. This addsrpcUrlSecret {name, key}: whennameis set, the entry becomesvalueFrom.secretKeyRefandrpcUrlis ignored. A name without a key fails the render.A second
CFG_CHAIN_RPC_URLSthroughenv.rawdoes not work as a stopgap: duplicate env names break the Argo CD diff, and on first apply the strategic merge foldsvalueandvalueFrominto one entry that pod validation rejects.Changes
templates/deployment.yaml:CFG_CHAIN_RPC_URLScomes from the Secret whenrpcUrlSecret.nameis set, otherwise the plain value as before.values.yaml,README.md:rpcUrlSecretwith empty defaults; README regenerated with helm-docs 1.14.2.ci/secret-rpc-values.yaml: installs with an emptyrpcUrland the URL in a Secret, soct installfails if this path breaks.With
rpcUrlSecretunset the render is byte-identical to 0.3.9 apart from thehelm.sh/chartlabel. That label is not on the pod template, so existing releases do not restart on upgrade.Testing
helm templateon Helm 3.11.2 (CI) and 3.19.4: chart defaults,ci/testnet-envs-values.yaml, a production relay's values,rpcUrlSecret: nulland a key without a name all render identical to 0.3.9 (chart label normalised). With the Secret set, only theCFG_CHAIN_RPC_URLSentry changes, and it appears exactly once.rpcUrlSecret.key is required when rpcUrlSecret.name is set.helm lint --strictwith each ci file, andct lintwith the CI config (version bump accepted).ct installon kind with both ci files: install and both helm tests pass.[sc-22327]