Repository navigation
feat(validator): read CFG_CHAIN_RPC_URLS from a Secret [sc-22327] - #339
Merged
Merged
Conversation
Add ghost.rpcUrlSecret and vao.rpcUrlSecret {name, key}. When name is
set, the container's CFG_CHAIN_RPC_URLS comes from valueFrom.secretKeyRef
and the plain rpcUrl is ignored. VAO uses its own pair when
vao.rpcUrlSecret.name or vao.rpcUrl is set, otherwise the ghost pair,
the same fallback vao.rpcUrl has today. A name without a key fails the
render. The new validator.rpcUrlEnvSource helper renders either form.
With the values unset the render is unchanged apart from the chart
label, which is not on the pod templates.
ci/testnet-envs-values.yaml now reads the ghost URL from a Secret and
VAO inherits it; ci/mainnet-envs-values.yaml keeps the plain path.
Bump validator to 0.9.0.
paulohpigatto
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #338 for the validator chart. Ghost renders
CFG_CHAIN_RPC_URLSfromghost.rpcUrl, and VAO fromvao.rpcUrlwith a fallback toghost.rpcUrl, so a target-chain RPC URL that carries an API key cannot come from a Secret.Changes
ghost.rpcUrlSecret {name, key}andvao.rpcUrlSecret {name, key}. Within a container the Secret wins over the plain URL. VAO uses its own pair whenvao.rpcUrlSecret.nameorvao.rpcUrlis set, otherwise the ghost pair, the same fallbackvao.rpcUrlhas today. A name without a key fails the render.validator.rpcUrlEnvSourcerenders either form for both Deployments.ci/testnet-envs-values.yamlnow reads the ghost URL from a Secret, and VAO inherits it.ci/mainnet-envs-values.yamlkeeps covering the plain path.With the new values unset the render is byte-identical to 0.8.2 apart from the
helm.sh/chartlabel, which is not on the pod templates. Releases that float on the chart version only see that label change.Testing
helm templateon Helm 3.11.2 and 3.19.4: defaults, both ci files as they are on main, a production validator's values,rpcUrlSecret: null,vao.rpcUrl: ""and keys without names all render identical to 0.8.2. Four Secret layouts (ghost inherited by VAO, explicit on both, VAO only, ghost Secret with a plainvao.rpcUrl) change only theCFG_CHAIN_RPC_URLSentries, once per container.ghost.rpcUrlSecretorvao.rpcUrlSecretwith a name and no key fails the render and names the path.helm lint --strictwith each ci file, andct lintwith the CI config.CFG_CHAIN_RPC_URLSfrom the Secret.Known, not from this PR
The validator
ct installfixtures already fail on main. Ghost 0.81.0 cannot load the config it downloads at start (An argument named "broadcast_mode" is not expected here), so the mainnet install times out andghost-test-connectionfails on the testnet fixture. I reproduced both with the unchanged 0.8.2 chart and the unchanged fixtures, and this PR gives the same helm test results. It needs a separate fix (a newer default image, or fixtures that pin a config).Merge after #338 has released: two overlapping Release Charts runs have dropped index entries before (#336).
[sc-22327]