Repository navigation
fix: tracks read from a OneLibrary USB report their real length (NP3-414) - #1
Merged
Merged
Conversation
…ad of a quarter of a second - Read content.length as whole seconds, the unit rekordbox writes, checked against three real exportLibrary.db exports - Store the test fixture's lengths in seconds and assert them as stored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OneLibraryAdapterdividedcontent.lengthby 1000 on the assumption that it is milliseconds. rekordbox writes it in whole seconds — the same unit as the PDB's track duration. Three realexportLibrary.dbexports read 195, 390, 297… for normal-length tracks.Downstream, Now Playing's mix processor treats a track as finished once it has been registered longer than its duration allows (NP3-405). A four-minute track that reports 0.25 s is "stale" two minutes after it was registered, so any deck that went on air later than that never reached the overlay. Sentry shows 790 of those suppressions across six users in 30 days (NP3-414, XDJ-XZ report).
durationiscontent.lengthas stored