Repository navigation
test: OneLibrary adapter fixture stores lengths in seconds (NP3-414) - #11
Merged
Merged
Conversation
…e real exports, so the publish passes again - Rewrite the fixture's content.length values from milliseconds to seconds, in both create-test-db.ts and the committed test-onelibrary.db - Assert durations as stored, matching onelibrary-connect 1.1.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onelibrary-connect 1.1.6 (chrisle/onelibrary-connect#1) reads
content.lengthas whole seconds, the unit rekordbox writes: three real exportLibrary.db exports read 195, 390, 297 for normal tracks. This repo's copy of the adapter spec still built its fixture in milliseconds and expected ÷1000. The publish job checks out onelibrary-connect at main, so publish run 36256252752 failed at Run tests.create-test-db.tsand the committedtest-onelibrary.dbnow store 300/240/180/210/225 secondsLocal: jest 504 passed (37 suites) against onelibrary-connect main.