Repository navigation
Archive readers accept either ymf domain shape - #109
Merged
Merged
Conversation
ymf is moving its archive domain from time_collections (one per space) to times (one list of instants, spaces inside each; cekees/ymf#23). Add Archiver.archive_collections, which gives the per-space view of either, and use it in findArchiveGrid, readMeshFromArchive, archived_times, clearh5 and the tests that read a domain back. No dependence on the new ymf: the same tests pass with the current ymf main and with ymf#23. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
cekees
added a commit
to proteustoolkit/proteus
that referenced
this pull request
Oct 27, 2026
test_the_timeout_is_scaled_for_a_slow_runner started a python that slept 1.2 s under a 0.5 s timeout scaled to 1.5 s, so it passed only if the interpreter started in under 0.3 s; on a loaded CI runner it did not (linux-64 py3.12 on cekees#109). Hand the wrapper a stand-in for subprocess.run instead and look at the timeout it passes on. The wrapper is now retrying_run(run), exposed through the launch_policy fixture. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of 3 for the time-outside-space archive format (design:
docs/design-time-outside-space.mdin cekees/ymf#22).ymf#23 changes
read_ymfto return{"times": [{time, spaces: {...}}]}instead of{"time_collections": [...]}. Proteus reads the old key in several places, andscripts/clearh5.pywould silently loop over nothing. This PR addsArchiver.archive_collections(domain), the per-space view of either shape, and uses it infindArchiveGrid,readMeshFromArchive,archived_times,clearh5(which also learns to truncate format 2 instants) and the tests that read a domain back.No behavior change with today's ymf. Order: this, then ymf#23, then the
Archiver.pywriter PR.Checked locally (extensions borrowed from another worktree's build; not a CI run): the archive tests (
test_archive_dtypes,_parallel_metadata,_v1_compat,_read_paths,_no_xml,test_hdf5_api_migration,test_archiver_write_field,test_gatherTimes) pass, 181 + 28, against both the current ymf main and the ymf#23 branch. That also means today's writer works with ymf#23 as is.🤖 Generated with Claude Code