Repository navigation
Archiver writes the document as instants (ymf archive format 2) - #110
Merged
Merged
Conversation
assemble_domain walks steps outermost and lets each collection join the instant at its time; the live append writes one record per instant, so a killed run loses a whole instant, never one space of it; inline archives build instants directly; archived_times is the instants; gatherTimes truncates instants. The HDF5 metadata layout and METADATA_FORMAT_VERSION are unchanged. A space first archived late is now found by a reader that does not know the step count (it used to stop at the first gap). Needs ymf archive format 2 (cekees/ymf#23). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of 3 for time-outside-space (design:
docs/design-time-outside-space.md, cekees/ymf#22). Stacked on #109 (base isnesting-readers) and needs cekees/ymf#23; draft until both merge, then retarget tomain.assemble_domainwalks steps outermost; each collection's grid joins the instant at its time. Result is atimesdomain._appendLiveStepwrites one record per instant (it was one per collection per step), so a killed run loses a whole instant.archived_timesreadstimes;scripts/gatherTimestruncates instants.METADATA_FORMAT_VERSION(2) are unchanged, so hot start and every existing.h5still work.readArchiveDomain. It now waits for a collection's first step.test/test_archive_instants.py(two spaces, one live record per instant, kill mid-instant, late space).Local run against the ymf#23 branch (extensions borrowed from another worktree; not CI): 193 archive-area tests pass, plus 71 more (
test_spatialtools, declared/fields).test_adr_problempassed 55 then stopped attest_an_l_shaped_region_converges_at_second_order, which fails because the borrowed environment has no working mesh generator for it (mvof triangle output missing); I did not run the tests after it.🤖 Generated with Claude Code