Repository navigation
feat(cli): add one-way mem put --watch (#110) - #225
Conversation
|
@waterbro-8 please review. Fork PR; I cannot request reviewers on this repo. |
waterbro-8
left a comment
There was a problem hiding this comment.
Code review APPROVE (not product 验收).
One-way put --watch is scoped correctly: quiet-interval ingest, no remote DELETE on local_gone, changed files reported not reingested, lock, JSONL cap, tests for ingest/auth/changed/dedupe/lock/cancel.
Note: cycle uses context.Background(), so SIGINT waits for an in-flight upload. Fine for this minimal tier.
Please rebase onto current main (includes #222) — mergeStateStatus is BEHIND.
|
Rebased locally onto current Cannot push from this OAuth token: GitHub rejects updating Local rebased heads: |
|
Tried again to unstick the behind-by-1 vs
Local rebase onto current
Local rebased heads (not pushed): |
Foreground poll watcher consumes the shared ingest core. New files ingest after one quiet interval; changed files are reported not re-ingested; local deletes never propagate.
bf68d03 to
3bc3d58
Compare
Tracking record
Refs #110. Implements R2/R3 (waterbro-8). Consumes
server/internal/ingestfrom #111 / PR #217.Summary
mem put <path> --watchis a foreground poll watcher:--intervaldefault 30s; single-instance flock; SIGINT/SIGTERM exit 0 between cycles--format json); JSONL under CLI state root capped at 200 cycleslocal_goneissues no deleteOut of scope: bidirectional sync, deletion propagation, Phase 2 sync drive, file revisions.
Validation ledger
go test ./cmd/mem/ -run TestWatchgo test ./cmd/mem/ ./internal/ingest/