Repository navigation
fix(index): report unwired generation execution honestly (#174) - #223
Conversation
|
@waterbro-8 please review. Fork PR; I cannot request reviewers on this repo. |
waterbro-8
left a comment
There was a problem hiding this comment.
Code review APPROVE (not product 验收).
Fail-closed matches #174: execution_wired: false on list/status/events/cancel/resume/discard; create/activate/rollback return 503 execution_unavailable without calling Service.Create/Activate/Rollback; create still 400s malformed JSON / empty profile_id first; tests assert the flag key is present and false.
Please rebase onto current main (includes #222) — GitHub mergeStateStatus is BEHIND. After rebase I will not re-approve unless the diff changes.
|
Rebased locally onto current Cannot push from this OAuth token: GitHub rejects updating Local rebased heads: |
|
Tried again to unstick the behind-by-1 vs
Local rebase onto current
Local rebased heads (not pushed): |
Advertise execution_wired=false and fail-closed create/activate/rollback with 503 execution_unavailable so operators cannot enter stuck-building or empty-workspace active states. Do not implement a worker executor.
e314278 to
7c9e002
Compare
Tracking record
Refs #174. Smallest resolution. Successor to dirty/unmerged #189, rebased onto current main (minus the #222 workflow-scope bump on the fork).
Summary
Index-generation HTTP still advertised
execution_wired: truewith no worker claiming targets. This PR makes the flag honest and fail-closed:execution_wired: falseon list/status/events/cancel/resume/discard503 execution_unavailableand never callService.Create/Activate/Rollback400for malformed JSON or emptyprofile_iddocs/INDEX_GENERATIONS.mdmatches the routes that existmap[string]any, not a bool zero value)Does not implement a worker executor (
ClaimTargetloop). No follow-up executor issue exists yet; that remains deferred.Validation ledger
go test ./internal/api/ -run 'TestIndexGeneration|TestExecutionWired|TestEmptyWorkspace'git diff --checkRisk / rollback
Read-only status remains. Mutating create/activate/rollback become actionable 503s instead of stuck or empty-active generations. Revert restores the old advertisement.