Skip to content

Fix misplaced Unified MCP specs breaking lint #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonnyt merged 2 commits into from
Aug 25, 2026
Merged

Fix misplaced Unified MCP specs breaking lint #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d05d4
Initial plan
Copilot Aug 25, 2026
c559894
test: move Unified MCP specs to the correct file
Copilot Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions spec/bundleup/mcp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,60 +265,3 @@ def json_response(payload)
end
end
end

RSpec.describe BundleUp::Unify::MCP do
subject(:unified) { described_class.new(api_key, connection_id) }

let(:api_key) { 'test-api-key' }
let(:connection_id) { 'conn_123' }
let(:url) { 'https://unify.bundleup.io/v1/mcp' }
let(:tool) { { 'name' => 'send_message' } }

def rpc(id, result)
{ 'jsonrpc' => '2.0', 'id' => id, 'result' => result }
end

# Handshake plus whatever follows, on one stub — a second stub_request for
# the same verb and URL would shadow this one.
def stub_session(*responses)
stub_request(:post, url).to_return(
{ body: rpc(1, { 'protocolVersion' => '2025-06-18' }).to_json,
headers: { 'Content-Type' => 'application/json' } },
{ body: '', status: 202 },
*responses
)
end

describe '#hosted' do
it 'targets the Unified server with a composite token' do
expect(unified.hosted).to eq(url: url, token: "#{api_key}.#{connection_id}")
end
end

describe '#list_tools' do
it 'lists tools against the Unified server' do
stub_session({ body: rpc(2, { 'tools' => [tool] }).to_json,
headers: { 'Content-Type' => 'application/json' } })

expect(unified.list_tools).to eq([tool])
end
end

describe '#call_tool' do
it 'requires a tool name' do
expect { unified.call_tool('') }.to raise_error(ArgumentError, /Tool name is required/)
end

it 'reuses one session across calls' do
stub_session(
{ body: rpc(2, { 'tools' => [] }).to_json, headers: { 'Content-Type' => 'application/json' } },
{ body: rpc(3, { 'content' => [] }).to_json, headers: { 'Content-Type' => 'application/json' } }
)

unified.list_tools
unified.call_tool('send_message')

expect(a_request(:post, url).with(body: /"method":"initialize"/)).to have_been_made.once
end
end
end
12 changes: 6 additions & 6 deletions spec/bundleup/unify/mcp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,18 @@ def stub_session(*responses)
end
end

describe '#tools' do
describe '#list_tools' do
it 'lists tools against the Unified server' do
stub_session({ body: rpc(2, { 'tools' => [tool] }).to_json,
headers: { 'Content-Type' => 'application/json' } })

expect(unified.tools).to eq([tool])
expect(unified.list_tools).to eq([tool])
end
end

describe '#tool' do
describe '#call_tool' do
it 'requires a tool name' do
expect { unified.tool('') }.to raise_error(ArgumentError, /Tool name is required/)
expect { unified.call_tool('') }.to raise_error(ArgumentError, /Tool name is required/)
end

it 'reuses one session across calls' do
Expand All @@ -51,8 +51,8 @@ def stub_session(*responses)
{ body: rpc(3, { 'content' => [] }).to_json, headers: { 'Content-Type' => 'application/json' } }
)

unified.tools
unified.tool('send_message')
unified.list_tools
unified.call_tool('send_message')

expect(a_request(:post, url).with(body: /"method":"initialize"/)).to have_been_made.once
end
Expand Down
Loading