Skip to content

Fix misplaced Unified MCP specs breaking lint - #7

Merged
sonnyt merged 2 commits into
mainfrom
copilot/fix-lint-failure
Aug 25, 2026
Merged

Fix misplaced Unified MCP specs breaking lint#7
sonnyt merged 2 commits into
mainfrom
copilot/fix-lint-failure

Conversation

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

The failing lint job was caused by a misplaced top-level RSpec.describe block in spec/bundleup/mcp_spec.rb, which triggered RSpec/MultipleDescribes. The same spec move also left spec/bundleup/unify/mcp_spec.rb asserting the old tools / tool API instead of the current list_tools / call_tool interface.

  • Spec layout

    • Remove the stray BundleUp::Unify::MCP example group from spec/bundleup/mcp_spec.rb
    • Keep provider MCP coverage scoped to the provider MCP spec file only
  • Unified MCP coverage

    • Update spec/bundleup/unify/mcp_spec.rb to match the current public API:
      • toolslist_tools
      • toolcall_tool
    • Preserve the existing handshake/session reuse assertions in the correct spec file
  • Net effect

    • Restores one top-level example group per spec file
    • Aligns Unified MCP tests with the implementation without changing production code
describe '#list_tools' do
  it 'lists tools against the Unified server' do
    expect(unified.list_tools).to eq([tool])
  end
end

describe '#call_tool' do
  it 'requires a tool name' do
    expect { unified.call_tool('') }.to raise_error(ArgumentError, /Tool name is required/)
  end
end

Co-authored-by: sonnyt <183387+sonnyt@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job lint Fix misplaced Unified MCP specs breaking lint Aug 25, 2026
Copilot AI requested a review from sonnyt August 25, 2026 23:24
@sonnyt
sonnyt marked this pull request as ready for review August 25, 2026 23:28
@sonnyt
sonnyt merged commit 52d0017 into main Aug 25, 2026
7 checks passed
@sonnyt
sonnyt deleted the copilot/fix-lint-failure branch August 25, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants