Resolve {project-root} by walking up to the nearest _bmad/ - #38
Merged
Merged
Conversation
Skills started inside a worktree or subfolder now find the _bmad/ install above them instead of assuming the working directory.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (30)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughChangesProject Root Resolution
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The root-resolution change is consistent across the supplied skill and workflow summaries. The inspected story workflow intentionally places artifacts under the resolved root, so no merge-blocking issue is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops through folders wide Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every skill now says
{project-root}is the nearest folder containing_bmad/, starting at the project working directory and moving up through its parents.The old line said
{project-root}paths resolve from the project working directory. That breaks when an agent starts inside a worktree or subfolder that has no_bmad/of its own, such asoss/.worktrees/<repo>/<branch>with_bmad/atoss/.We tested both wordings in sandboxes with identical decoy installs, across Claude Code, Codex, opencode (GLM) and Antigravity models. The new wording found the right
_bmad/43 of 45 times. The old wording managed 31 of 45 and wrote to the wrong copy 3 times.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qrjf7zEvqbDcipTM3UYZuP
Summary by CodeRabbit