Repository navigation
fix(macos): keep unsupported memory controls visible and localize memory forms - #344
Conversation
…ing them The bot memory sheet hid Reflect and the provider-controls button when the capability was not negotiated. Keep both visible and disabled; the regression asserts they stay visible. Refs #101.
|
findings 2a54889 part 1/1 Scope: independent review of PR #344 at exact head 2a54889 against cached origin/main f84e02a in the local checkout, branch roadmap/p3/ship101-macos-memory. All nine changed files read. No build, no Cargo, no gh/API, no source edits, no publication. The repository localization scanner's non-green state is accepted as a verification limit: the author's run reported no missing translation and no placeholder mismatch, and the scanner only sees literal must
Scope note for the lead: findings 1 and 2 touch lines this PR did not itself modify, so they are pre-existing gaps, not regressions. They are in scope for this slice because the PR's own new sentence at should
Checked, no finding
Verdict: changes. Two |
|
review-receipt sha=2a5488958920f62e3cebc5635e08175d8b19f754 role=review round=1 model=MiniMax-M3.1-Flash-Preview session=01a13b22-66c3-736d-8097-e304a6e2efc3 verdict=changes findings=#344 (comment) findings_sha256=bd27df2c9369a1973d003f28f05c845d1aa635ab031c533acf002401cbdf0deb |
|
findings 423dd35 part 1/1 Scope: independent round 2 review of PR #344 at exact published head 423dd35 in the local checkout, branch roadmap/p3/ship101-macos-memory, composed on top of main 755ecf1. Verified local HEAD equals the published SHA and Prior round 1 findings are re-verified here, not assumed from the checkpoint's summary. The full-bundle build and codesign proof in the author checkpoint is explicitly bound to the earlier head and is deliberately not carried forward: this review establishes no build evidence for 423dd35, only the scoped native fixture, Verification of round 1 must 1 — feature menu localization: fixed
Verification of round 1 must 2 — connection, entry and error surfaces: fixed
Verification of round 1 should — confirmation fragments: fixed
mustNone. shouldNone that block merge. Two notes for the record, both verified as correct and needing no change:
Checked, no finding
Verdict: pass. Both round 1 |
|
review-receipt sha=423dd35214af0d3215b55fd923ce3773d326f6d6 role=review round=2 model=MiniMax-M3.1-Flash-Preview session=01a13b22-66c3-736d-8097-e304a6e2efc3 verdict=pass findings=#344 (comment) findings_sha256=405368f3f019e6e1239d7fb7f8ce915e80d79a7d0ff9d70a290be57aadde22c6 |
|
findings 423dd35 integration round 1 part 1/1 Binding and scope
Source/composition gate: APPROVE, local-source scopedLocal origin/main resolves to 755ecf1. Its merge-base with exact head is that same SHA. No network refresh was authorized: this proves composition with the locally available main, not freshness of hosted main. Merge 7d7d56f has parents 2a54889 and 755ecf1. A fresh local git merge-tree of those parents produces tree 283788e2d7c1a9f10e889676685ace45652c1073, exactly the committed merge tree. No conflict-resolution edits exist in that composition. Main's incoming workflows, ARCHITECTURE.md, releases subject and release-pr-gates fixture have no diff against exact head. This integration session creates no commit. Prior must 1: fixedMemoryAdvancedViewController.swift:42 localizes negotiated feature presentation through L. The feature still comes from supported[indexOfSelectedItem]; action selection retains raw representedObject. All 13 feature display keys and known verb labels have Chinese entries. Native fixture exercises ordered Chinese OpenViking feature titles and verifies command().action remains list. Capability negotiation and transport parameters remain unchanged. Prior must 2: fixedMemoryConnectionViewController.swift:183-185 routes OpenViking binding labels and accessibility labels through L; all four previously missing label keys now exist. MemoryViewController.swift:63 uses the shared translated MemoryActionButton entry. MemoryFormViewController.swift:122-128 renders known local UI/draft/setup errors through translated keys without displaying arbitrary backend payloads. Error enum declarations and table entries agree, including the intentionally raw lancedb_cloud_transport_unavailable key. Native fixture exercises binding labels, service entry and one rendered error from each enum. Prior should: fixedMemoryEmbeddingViewController.swift:78 and BotMemoryServiceViewController.swift:260 localize local CPU and whole bot bank confirmation fragments without changing actual endpoints, document IDs or request targets. Other checked properties
Local execution evidence gate: CLOSED for scoped runs onlyThis session compiled and executed the fixture binaries from this checkout. Successful traced native run is captured in artifact://12:13-35 and this session's background-result record:
Initial synchronous native invocations returned only an incomplete tool response, Compiled 3 packages, without usable completion evidence. Those responses are not acceptance proof; the complete traced background run above is the evidence used here. Tool inconsistency was reported locally. Hosted/publication gate: UNKNOWN / UNBOUNDNo hosted check status or check-run URL was queried. Hosted main freshness, hosted required checks and publication are unknown. Local source approval and fixture success do not establish hosted Tests success or merge readiness. No ready or merge authorization is issued. Earlier full bundle/codesign evidence belongs only to 2a54889, not this head. No installed-app navigation, live backend acceptance, complete keyboard traversal, checkbox accessibility role or VoiceOver proof is established. Earlier non-green whole-localization scanner remains a recorded limit; it was not rerun, suppressed or claimed green. Issue #101 installed-app/live-backend acceptance remains outside this source-scoped integration proof. Findings and dispositionmust: none in reviewed local source/composition. Source/composition: APPROVE against local main 755ecf1. Changed files reviewed
|
|
review-receipt sha=423dd35214af0d3215b55fd923ce3773d326f6d6 role=integration round=1 model=gpt-6.1-sol session=01a13b5a-1475-7782-9fb6-6fa63c4d9afc verdict=pass findings=#344 (comment) findings_sha256=137d392ad13a0f3e9e3d1ed103c22cede6ee3accecdcd5842145e2f5d8ea1783 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Unsupported AppKit memory actions remain visible and disabled until negotiated capabilities permit them. Memory forms localize labels, consent warnings, validation errors and target descriptions while preserving wire calls, masking, confirmation and accessibility.
Integrates main through 1b58fa7, preserving the merged desktop direct-label functions and mobile forms exactly. The superseded label-map scanner and its tests are removed; the native form scanner remains.
Validation: 7 remaining scanner tests pass; localization audit, docs and diff checks pass. Prior AppKit memory fixtures pass and remain applicable to unchanged memory sources. One independent source review and parent pinpoint P2 closure are retained; the old label-map mechanism has been replaced by reviewed main. Hosted CI is queued, not passed. Physical/native E2E acceptance NOT_RUN, deferred.