Skip to content

[P3][Memory-Retrieval] Complete macOS memory controls and acceptance #101

Open

Description

@bloodf

User outcome

A Mac user configures memory connections, embedding profiles and per-bot consent and sees health and delivery state.

Metadata

  • Phase: P3 · Kind: leaf · Priority: personal computers stay first; this stream is independent of VM UI work
  • Readiness: ready — core and Foundation models exist; sheet attachment is the gap
  • Relative size: L

Current behavior and evidence

Per docs/architecture/memory-ui.md, the Foundation/TypeScript adapters exist and native account/per-bot controls are not attached on macOS and desktop; the memory service core already exists and is not rebuilt here. macOS has macos/Sources/Lorca/Model/MemoryService.swift and MemorySetup.swift plus the local MemoryViewController.swift editor with hash conflict protection; no connection/consent sheet is attached.

Proposed incremental behavior and reuse anchors

Attach the existing Foundation models to AppKit sheets: account connections (keep/replace/clear secret patches), embedding profiles, per-bot consent drafts (all remote capture off by default), capability-driven panels, delivery queue, fenced deletion, setup previews. Controls follow negotiated capabilities, not a backend-name matrix.

License and dependency constraints

Native Beans work under the repository's GPL-3.0-only licence; no new dependency.

Ordered tasks and subtasks

  • 1. Account connections sheet
  • 2. Embedding profile sheet
  • 3. Per-bot consent panel (approval flow for remote query/capture)
  • 4. Health, delivery-queue and delete-pending status
  • 5. Accessibility labels, keyboard operation, English and Simplified Chinese strings
  • 6. Update docs/architecture/memory-ui.md

Affected surfaces

  • macos/Sources/Lorca/Sheets
  • macos/Sources/Lorca/Model/MemoryService.swift
  • macos/Tests/MemoryServiceDraft.swift
  • docs/architecture/memory-ui.md

Failure, security, privacy and data-preservation cases

  • Secrets never echo back; masked flags only.
  • Unattended capture stays refused (enforced_spending_policy_required).
  • Unknown backend/schema versions fail decoding instead of selecting a substitute.
  • Nothing in the sheet triggers a live remote retain or reflect.

Acceptance

  • Create a connection with keep/replace/clear secret patches
  • Bind a bot and enable recall with its consent approvals
  • Changing the connection clears consent approvals
  • Missing capability disables a control rather than hiding it
  • Health, delivery_unknown and delete-pending are distinguishable
  • Every control has an accessible name

Verification

  • Automated: Future-only (none run while drafting): bun run check:docs
  • Manual scenario: On a Mac, configure a fixture connection, enable recall for one bot, read status; do not run live remote retain.
  • Plain-language note: commands above were not executed during roadmap drafting; run only those relevant to the change.

Prerequisites

Blocked by: none.

Completion evidence

  • Linked PR with passing checks listed above
  • Manual scenario result recorded (date, platform, outcome)
  • Affected docs/architecture/*.md updated in the same change; bun run check:docs passes

Current delivery phase

P3 — Profiles memory and artifacts. This difficulty-first assignment supersedes earlier phase/priority wording. Explicit dependencies remain required; same-phase work follows dependency order. Stable keys (including p0-* keys) remain unchanged.

Managed roadmap links

Parent: [P3][Epic] Memory retrieval: evidence on top of the existing foundation
Blocked by: None.

Scope and acceptance alignment

The memory controls baseline is already attached; current architecture documentation and the later issue receipts supersede the original unattached-sheet description. Draft #344 is the unsupported-controls visibility increment. Complete the remaining exact-head checks and native fixture/VoiceOver acceptance rather than rebuilding the memory UI. A draft or passing source review does not close the native acceptance gate.

Activity

  1. added
    roadmapManaged Beans capability roadmap
    phase:P4Roadmap phase P4; not a blanket dependency
    area:memoryBeans memory workstream
    on Oct 7, 2026
  2. changed the title [-][P4][Memory-Retrieval] Attach memory-service controls in the macOS app[/-] [+][P3][Memory-Retrieval] Attach memory-service controls in the macOS app[/+] on Oct 7, 2026
  3. added
    phase:P3Roadmap phase P3; not a blanket dependency
    readyReady to pick: prerequisites met, owner free
    and removed
    phase:P4Roadmap phase P4; not a blanket dependency
    on Oct 7, 2026
  4. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Task contract — 2026-10-13

    • Readiness: ready. none found; macOS has BotMemoryServiceViewController.swift and MemoryAdvancedViewController.swift but no account connections or embedding profile sheet under macos/Sources/Beans/Sheets.
    • Depends on: none. Successors: [P3][Epic] Memory retrieval: evidence on top of the existing foundation #16, [P3][Memory-Retrieval] Show source and age of recalled evidence #104.
    • Source area: macos/Sources/Beans/Sheets, macos/Sources/Beans/Model/MemoryService.swift, macos/Sources/Beans/Model/MemoryUI.swift, macos/Tests/MemoryServiceDraft.swift
    • Current owner: unassigned; a worker claims it by commenting its branch and name here
    • Next action: Add an account MemoryConnectionsViewController under macos/Sources/Beans/Sheets driven by Model/MemoryService.swift, wired from the Settings Memory action.
    • Acceptance: Create a connection with keep/replace/clear secret patches; bind a bot and enable recall with consent approvals; changing the connection clears approvals; missing capability disables rather than hides; health, delivery_unknown and delete-pending distinguishable; accessible names; bun run check:docs.
    • Flow: focused check in an isolated target, one independent review, PR with -R bloodf/beans, merge by the publishing authority, post-merge check. Source PASS is not installed-app or live-service acceptance.
  5. bloodf commented on Oct 13, 2026

    @bloodf
    OwnerAuthor

    Claimed: branch roadmap/p3/ship101-macos-memory (worktree ship101-macos-memory-20261013), commit b672917 on origin/main 138245f. Account connections, embedding profiles, consent and status sheets already exist under macos/Sources/Beans/Settings and Sheets. The only acceptance gap was that the bot sheet hid Reflect and provider controls when a capability was absent; they are now disabled and visible. Regression in macos/Tests/MemoryUIFlows.swift, run via macos/Tests/run-memory-ui.sh: pass. Not pushed; native app acceptance not run.

  6. changed the title [-][P3][Memory-Retrieval] Attach memory-service controls in the macOS app[/-] [+][P3][Memory-Retrieval] Complete macOS memory controls and acceptance[/+] on Oct 19, 2026
  7. added
    priority:highUrgency: high; next important delivery or correctness work. Independent of roadmap phase.
    on Oct 19, 2026
  8. added
    platform:macosTarget scope: macOS. Does not imply implementation or acceptance; require target-specific evidence.
    on Oct 19, 2026
  9. bloodf commented on Oct 19, 2026

    @bloodf
    OwnerAuthor

    Engineering review update — PR #344

    Exact head 923126c now passes the AppKit memory UI runner and all three Foundation executables on macOS, plus docs and strings-file lint. Exercised Chinese labels, disabled discoverability, keyboard editing focus, accessibility titles and guarded drafts. The native memory localization scanner now resolves helper display arguments and explicit finite error/action keys; seven positive/negative scanner tests pass (13 assertions). Memory-specific unused-key false positives are resolved; whole l10n remains non-green on the original unrelated macOS1/phone10/desktop4 unused keys. Installed-app navigation, full keyboard traversal, VoiceOver and real CLI/backend flow remain unverified; no live retain or reflect ran.

    The PR remains open as Draft. This evidence does not complete this issue or its platform acceptance. Existing phase, labels and dependencies are preserved; shared aggregate exact-head CI acceptance remains #373.

    Independent rereview confirms nested comments, multiline/raw source samples and balanced conditional parentheses are handled without counting unused labels.

  10. bloodf commented on Oct 19, 2026

    @bloodf
    OwnerAuthor

    PR #344 is now repaired at fb6f88f1aa8d03d6b240edfb90ee09ffd5644159. The remaining localization diagnostics were investigated rather than suppressed: four obsolete entries removed, phone dynamic keys made explicit at render time, finite translated desktop maps recognized, and five truly missing delivery translations added consistently with #346. The full l10n audit now passes (1288 macOS / 492 phone / 1164 desktop keys). Final-head recorded exits also pass nine scanner regressions, 166 phone tests, both client typechecks, docs/plist/whitespace. Earlier native fixture output is historical LIMITED_EVIDENCE, not exact-final-head installed-app acceptance. The PR remains open/Draft: installed-app navigation, VoiceOver, real CLI and shared #373 exact-head CI acceptance remain outstanding. No issue closure, phase, cycle, label or dependency changes.

  11. bloodf commented on Oct 19, 2026

    @bloodf
    OwnerAuthor

    PR #344 now has reviewed repair head 2b7cc9aadbd6e3efa661a92951babd417f115fc9 pushed normally, preserving branch history. Its minimal shared CI prerequisites are integrated.

    Published head: 2b7cc9aadbd6e3efa661a92951babd417f115fc9. Immutable command/head/exit/log-hash receipts record: Full localization audit: 1288 macOS, 492 phone, 1164 desktop keys with zero problems. Nine scanner tests/19 assertions, phone: 166 tests/1292 assertions, both TypeScript checks and docs/catalog/full-PR whitespace. AppKit+three Foundation fixtures passed at fb6f88f; their source is unchanged by this shared composition.

    Source string audits and host AppKit fixtures do not establish installed-app acceptance on every platform.

    This head is now pushed and remains Draft. Its own required hosted checks must complete successfully before a readiness decision; queued or running checks are not passes. Canonical shared checks informed integration but do not replace this PR's final-head matrix. No merge, auto-merge or deployment is requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:memoryBeans memory workstreamphase:P3Roadmap phase P3; not a blanket dependencyplatform:macosTarget scope: macOS. Does not imply implementation or acceptance; require target-specific evidence.priority:highUrgency: high; next important delivery or correctness work. Independent of roadmap phase.readyReady to pick: prerequisites met, owner freeroadmapManaged Beans capability roadmaptype:implementationRoadmap implementation

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions