Wallet: Fix - BIP-05 - #2404
Closed
gabrielbazan7 wants to merge 1 commit into
Closed
Wallet: Fix - BIP-05#2404gabrielbazan7 wants to merge 1 commit into
gabrielbazan7 wants to merge 1 commit into
Conversation
This was referenced Sep 18, 2026
gabrielbazan7
changed the title
Collaborator
Author
|
added here: #2405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Closes BIP-05 by encrypting the whole WALLET store instead of a hand-picked list of fields.
To make it affordable, it first stops persisting two things that never survive a restart anyway: the BWC client's transport config (
request,bulkClient,timeout,_events…, re-created bygetClient()on every rehydrate) and the fieldsbuildWalletObjrebuilds (balance,pendingTxps,isScanning,chainName,badgeImg).Numbers
So this costs ~66 ms more per write than today, at 4–11 writes per session, and covers every secret in the store instead of a list that drifts.
Encrypting field-by-field — what the ticket literally asks for — is the most expensive option of all, three times this PR: crypto-js derives a key on every call, so 210 small encryptions cost more than one pass over the whole store.