Wallet: Ref - stop persisting bwc client config - #2400
Closed
gabrielbazan7 wants to merge 1 commit into
Closed
gabrielbazan7 wants to merge 1 commit into
gabrielbazan7 wants to merge 1 commit into
Conversation
Collaborator
Author
|
added here: #2404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet object in the store is a merge of the BWC client instance, so every persist was also writing the client's transport config (request, bulkClient, timeout, logLevel, bp_partner, _events). None of it survives a restart — bootstrapWallets builds a fresh client on every rehydrate — so it was ~60KB written on each save just to be discarded. Measured on a device with 47 wallets: persist:root went from 167KB to 102KB (-39%).