Repository navigation
Conversation
The "has OS thread name" tests were compiled whenever `pthread_getname_np()` exists, but they also need a working `SetOsThreadName()`. Replace the `HAVE_PTHREAD_GETNAME_NP` guard with a runtime probe. If it fails, log a warning and return from the three tests.
This covers code paths for illumos-based systems.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Regarding the failing test ( diff --git a/test/mp/test/listen_tests.cpp b/test/mp/test/listen_tests.cpp
index 41fb05a..d8d4984 100644
--- a/test/mp/test/listen_tests.cpp
+++ b/test/mp/test/listen_tests.cpp
@@ -253,8 +253,8 @@ KJ_TEST("ListenConnections handles a client that disconnects before being accept
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
-#ifndef __APPLE__
- // No error is expected on platforms other than macOS.
+#if !defined(__APPLE__) && !defined(__sun)
+ // No error is expected on platforms other than macOS and illumos.
KJ_REQUIRE(!accept_error_seen());
#endif
KJ_EXPECT(server.DisconnectedCount() == (accept_error_seen() ? 0 : 1));
|
Yeah. I've already applied the patch in https://github.com/hebasto/bitcoin-core-nightly. |
Yeah, I noticed it, but that patch is for Cap'n Proto. What I suggested is a diff for test code in this repo, as is done for the macOS job. |
The new CI job covers code paths for illumos-based systems.
Draft for now, as two tests that currently fail on illumos need fixing first: