Repository navigation
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. |
hebasto
force-pushed
the
261115-setname_np2
branch
2 times, most recently
from
November 15, 2026 17:56
4f8bd3f to
0231925
Compare
On platforms that provide only the 2-argument `pthread_setname_np()` function, such as illumos, none of the branches in `SetOsThreadName()` matches, so threads are left unnamed. As `pthread_getname_np()` is available there, the thread name tests fail. Introduce the `HAVE_PTHREAD_SETNAME_NP_2ARG` configuration macro, which represents the availability of that function, and use it in `SetOsThreadName()`. Platforms already handled by another branch are not affected.
hebasto
force-pushed
the
261115-setname_np2
branch
from
November 15, 2026 18:02
0231925 to
1a59d5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On platforms that provide only the 2-argument
pthread_setname_np()function, such as illumos, none of the branches inSetOsThreadName()matches, so threads are left unnamed. Aspthread_getname_np()is available there, the thread name tests fail.Introduce the
HAVE_PTHREAD_SETNAME_NP_2ARGconfiguration macro, which represents the availability of that function, and use it inSetOsThreadName().Platforms already handled by another branch are not affected.
Additionally, the first commit documents the platforms for every branch in
SetOsThreadName(), as suggested by ryanofsky in #324.