ConvexHullHelper: Speed up ReduceFace with bitset - #409
Closed
CallumDev wants to merge 1 commit into
Closed
Conversation
CallumDev
force-pushed
the
convex-hull-faster
branch
from
August 8, 2026 12:03
48852f2 to
f72ceab
Compare
Member
|
#412 now handles this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a very large amount of convex hulls in my project I noticed
ReduceFacewas spending a large amount of time inQuickList<int>.Contains(), particularly on inputs with large amounts of points.This PR has ReduceFace maintain a bitset of values present in reducedIndices, and measurably cuts down on the run time in my project.