Repository navigation
Fix dragging layers into and out of groups - #158
Merged
git-chad merged 15 commits intoOct 1, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
 |
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
git-chad
force-pushed
the
git-chad/v3-displaced-rings
branch
from
October 1, 2026 07:04
7f25982 to
72ee931
Compare
git-chad
force-pushed
the
git-chad/v3-group-drag-drop
branch
from
October 1, 2026 07:04
4e5a1de to
033eb38
Compare
git-chad
changed the base branch from
git-chad/v3-displaced-rings
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a child beyond its group previously changed its visual position without changing group membership. Layer handles now support reparenting and reordering in one atomic drop, so the visible hierarchy agrees with rendering and saved projects.
Group centers accept children (and open collapsed groups). Row edges mark before/after destinations; the left gutter lets a layer move to an ancestor level, including leaving the scene’s only group. Groups move with their complete subtrees. A group highlight/insertion line and destination message show the proposed move while the tree stays stable. Escape, lost capture, and releases outside the list cancel; long lists scroll near their edges. Invalid cycles, locked destinations, and excessive nesting are rejected. Existing keyboard menu/Properties alternatives remain available.
Stacked on #157 (
git-chad/v3-displaced-rings), under V3 integration #150. Ring defaults are unchanged and remain for the user to tune. Nothing merges to main until V3 is complete.Validation (CI validation/composition and preview deployment pass):
bun run checkpasses (three pre-existing local lint warnings).bun run test:compositionpasses with new drop-state regression coverage, including atomic mutation, subtree ordering, collapsed targets, cycles/depth/locks, undo/redo, and real project hydration.bun tests/composition/group-drag-ui.mjspasses against the local editor: desktop/mobile gestures, real touch input, drop feedback, nested/outdent moves, Escape/outside cancellation, long-list scrolling, UI undo/redo, and actual .lab download/import.The pointer test runs against a local editor using SHADER_LAB_URL (default localhost:55000); store/hydration regressions run in the existing CI composition suite. Updated
tests/composition/GROUPS-MANUAL-QA.mddescribes the focused user check. User acceptance is pending.