Skip to content

Add Photographic Cells and user-curated ring defaults - #159

Merged
git-chad merged 18 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-photographic-cells
Oct 1, 2026
Merged

git-chad merged 18 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-photographic-cells

Conversation

@git-chad

@git-chad git-chad commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Photographic Cells reveals rectangular blocks selected from a photo’s light areas, dark areas, or a seeded random pattern. The interiors retain full image detail. Cutout clears gaps and unselected cells; inside a group those holes reveal external layers. Keep Image preserves the original photograph and adds only the selected outlines.

Adds cell size/aspect, staggered row irregularity, selection threshold/inversion, seed, gaps, soft edges, and colored outlines. Includes editor/runtime rendering, public config export, grouped coverage, and a photographic catalog preview. This is the first prototype of the cell/block family in roadmap 3.2–3.3; temporal video refinement and wider artistic-reference/performance validation remain open.

Also applies the user’s supplied defaults to newly added Displaced Rings: 22 half-discs, radius 2, 45° per ring, zero offset/gap, Distort output. Saved explicit parameters are unchanged; missing saved fields retain the old values and renderer fallbacks remain unchanged. The roadmap records deferred Pass Through groups and a proposed Circle/Triangle/Square extension for later discussion; no new ring shapes are implemented here.

Stacked on #158 (git-chad/v3-group-drag-drop), under integration #150. Nothing merges to main until V3 is complete.

Validation:

  • bun run check passes (three pre-existing local lint warnings).
  • bun run test:composition passes with all frozen baselines, ring-default compatibility checks, and 104 editor/runtime GPU cases for cells.
  • New coverage includes preserved photographic detail, tone/random/inverted selection, deterministic seeds, gaps/soft edges/outlines, opacity, parameter extremes, and rectangular output.
  • Actual editor hydration, history restoration, save/reopen, group isolation, exported headless runtime config, and preview/PNG checks pass.
  • Local browser test passes for catalog insertion, cell selection/output/threshold/size/outline controls, and the new ring defaults. Photographic output and editor controls inspected.

The user accepted the layer as a useful prototype and reported outline thickening when Gap changes. Fixed that in editor/runtime by subtracting inset coverage instead of multiplying overlapping edge fades; 64 added GPU cases check visible stroke width across gaps, widths, softness, and both output modes. The old implementation fails the regression.

Added durable agent instructions and a visual-reference index. The connected stepped silhouettes/perimeter contours in reference 11 and broad color regions/fine dots in reference 05 remain explicit unfinished visual scope. All sixteen references are backed up locally, outside the product bundle. See tests/composition/PHOTOGRAPHIC-CELLS-MANUAL-QA.md for the focused test and prototype limits.

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 7:05am UTC

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR adds Photographic Cells across the editor and public runtime, including tone/random selection, cell geometry, cutout and keep-image output, outlines, persistence, export, catalog presentation, and composition coverage. It also applies curated defaults to newly created Displaced Rings while preserving missing saved parameters with the previous defaults.

  • Adds matching editor and package-runtime shader implementations.
  • Integrates the effect with layer creation, rendering, project hydration, and runtime config export.
  • Adds broad GPU, persistence, grouping, and preview/export coverage.
  • Updates documentation and manual QA guidance for both effects.

Reviews (1) · Last reviewed commit: "Add photographic cell cutouts and curate..."

…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
@git-chad
git-chad force-pushed the git-chad/v3-group-drag-drop branch from 4e5a1de to 033eb38 Compare October 1, 2026 07:04
@git-chad
git-chad force-pushed the git-chad/v3-photographic-cells branch from 8e988df to b995773 Compare October 1, 2026 07:04
@git-chad
git-chad changed the base branch from git-chad/v3-group-drag-drop to git-chad/shader-lab-v3-plan October 1, 2026 15:12
@git-chad
git-chad merged commit b995773 into git-chad/shader-lab-v3-plan Oct 1, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — b9957732 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant