Repository navigation
Add Photographic Cells and user-curated ring defaults - #159
Merged
git-chad merged 18 commits intoOct 1, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
|
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
git-chad
force-pushed
the
git-chad/v3-group-drag-drop
branch
from
October 1, 2026 07:04
4e5a1de to
033eb38
Compare
git-chad
force-pushed
the
git-chad/v3-photographic-cells
branch
from
October 1, 2026 07:04
8e988df to
b995773
Compare
git-chad
changed the base branch from
git-chad/v3-group-drag-drop
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photographic Cells reveals rectangular blocks selected from a photo’s light areas, dark areas, or a seeded random pattern. The interiors retain full image detail. Cutout clears gaps and unselected cells; inside a group those holes reveal external layers. Keep Image preserves the original photograph and adds only the selected outlines.
Adds cell size/aspect, staggered row irregularity, selection threshold/inversion, seed, gaps, soft edges, and colored outlines. Includes editor/runtime rendering, public config export, grouped coverage, and a photographic catalog preview. This is the first prototype of the cell/block family in roadmap 3.2–3.3; temporal video refinement and wider artistic-reference/performance validation remain open.
Also applies the user’s supplied defaults to newly added Displaced Rings: 22 half-discs, radius 2, 45° per ring, zero offset/gap, Distort output. Saved explicit parameters are unchanged; missing saved fields retain the old values and renderer fallbacks remain unchanged. The roadmap records deferred Pass Through groups and a proposed Circle/Triangle/Square extension for later discussion; no new ring shapes are implemented here.
Stacked on #158 (
git-chad/v3-group-drag-drop), under integration #150. Nothing merges to main until V3 is complete.Validation:
bun run checkpasses (three pre-existing local lint warnings).bun run test:compositionpasses with all frozen baselines, ring-default compatibility checks, and 104 editor/runtime GPU cases for cells.The user accepted the layer as a useful prototype and reported outline thickening when Gap changes. Fixed that in editor/runtime by subtracting inset coverage instead of multiplying overlapping edge fades; 64 added GPU cases check visible stroke width across gaps, widths, softness, and both output modes. The old implementation fails the regression.
Added durable agent instructions and a visual-reference index. The connected stepped silhouettes/perimeter contours in reference 11 and broad color regions/fine dots in reference 05 remain explicit unfinished visual scope. All sixteen references are backed up locally, outside the product bundle. See
tests/composition/PHOTOGRAPHIC-CELLS-MANUAL-QA.mdfor the focused test and prototype limits.