Skip to content

Add Displaced Rings with grouped photographic cutouts - #157

Merged
git-chad merged 14 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-displaced-rings
Oct 1, 2026
Merged

git-chad merged 14 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-displaced-rings

Conversation

@git-chad

@git-chad git-chad commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Displaced Rings fragments photography into transformed circular bands or half-discs. Output → Cutout leaves transparent gaps; placing the photo and effect inside a group reveals external background layers while preserving their isolation. Output → Distort retains the original image between bands.

Adds 1–128 rings, center/radius/distribution, alternating/progressive/seeded offsets, rotation per ring, progressive image scale, gaps, and soft edges. Editor/runtime rendering, public config export, catalog thumbnail, and grouped controls are included. A dedicated transform composition role interpolates color and coverage with layer opacity; existing source/effect and saved Mask behavior remain unchanged.

This is the first prototype from roadmap 3.2–3.3, stacked on #156 (git-chad/v3-transparent-text), under integration #150. Basic geometric masks remain postponed and Blob Tracking's quality/mask review remains low priority. Individual ring handles, coverage inversion, broader video/export performance, and artistic-reference curation remain follow-up work. Nothing merges to main until V3 is complete.

Validation (CI validation/composition and preview deployment pass):

  • bun run check passes (three pre-existing local lint warnings).
  • bun run test:composition passes, including all frozen legacy baselines and 34 new editor/runtime GPU cases: identity through 128 bands, 48 distinct radial bands, clean coverage, seeded offsets, and rotated color/alpha.
  • Real editor hydration, history restore, save/reopen, group isolation, exported runtime config, and preview/PNG comparisons pass.
  • Browser UI check passes: catalog insertion, Cutout/Half-discs selection, and changing the count to 128 and back to 8.
  • Photographic preview inspected. User visual acceptance is pending; see tests/composition/DISPLACED-RINGS-MANUAL-QA.md.

The photographic test thumbnail intentionally uses stronger half-disc displacement than the default to expose gaps/overlaps. Logged SwiftShader timings include readback and do not establish real-time hardware performance.

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 7:05am UTC

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

Adds Displaced Rings to the editor and public runtime, including grouped Cutout coverage and Distort output.

  • Introduces configurable ring geometry, displacement patterns, rotation, scaling, gaps, and softness.
  • Adds a transform composition role that interpolates color and coverage with layer opacity.
  • Integrates catalog, persistence/export paths, runtime rendering, documentation, preview media, and composition tests.

Reviews (1) · Last reviewed commit: "Add displaced rings with grouped photogr..."

…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
@git-chad
git-chad force-pushed the git-chad/v3-transparent-text branch from 63948d7 to c358bb5 Compare October 1, 2026 07:04
@git-chad
git-chad force-pushed the git-chad/v3-displaced-rings branch from 7f25982 to 72ee931 Compare October 1, 2026 07:04
@git-chad
git-chad changed the base branch from git-chad/v3-transparent-text to git-chad/shader-lab-v3-plan October 1, 2026 15:12
@git-chad
git-chad merged commit 72ee931 into git-chad/shader-lab-v3-plan Oct 1, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — 72ee931f Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant