Skip to content

V3: insert text over transparent backgrounds - #156

Merged
git-chad merged 13 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-transparent-text
Oct 1, 2026
Merged

git-chad merged 13 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-transparent-text

Conversation

@git-chad

Copy link
Copy Markdown
Collaborator

New text now appears as opaque white lettering over the existing composition. It uses Normal/filter composition with a transparent background, so designers can add text without switching away from mask mode or selecting Screen. Background Opacity remains editable for deliberate solid or translucent backgrounds.

Stacked on #155 (git-chad/v3-editor-groups) within the V3 integration PR #150. No merge to main until V3 is complete.

Saved text keeps its explicit opacity, blend, and mask settings. Files missing backgroundAlpha receive the previous solid fallback during actual editor/viewer hydration; runtime fallback behavior is unchanged. New saves retain explicit settings without another file-version bump.

The roadmap also records the user's priority changes: basic geometric masks are postponed; displaced rings are the existing phase-3 family, with offset half-discs and tailored coverage modes to explore; Blob Tracking gets a low-priority quality/mask review in 6.3.

Validation

  • bun run check — passed with existing lint warnings.
  • MCP generation/typecheck — passed; no reference snapshot changes.
  • bun run test:composition — passed, including unchanged frozen legacy scenes and the existing alpha/group suites.
  • New coverage: 24 real hydration combinations for saved text; 18 editor/runtime pixel checks for glyph opacity/color, clear background, soft edges, partial opacity, solid background, and omitted runtime settings; save/reopen and preview/PNG equality.
  • Editor-only change; empty changeset records that no package release is needed.

Manual check

Add a new Text layer above a photo. Expected: opaque white letters with the photo visible around them, no black rectangle, and Normal blend. Change Text Color; only the letters should change. Set Background Opacity to 1 for a solid black background, then back to 0 to reveal the photo. Save/reopen and confirm the same appearance.

Await user confirmation before starting the displaced-ring prototype. This PR does not implement drag-to-position, text-limit changes, basic shape masks, or Blob Tracking changes.

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 7:05am UTC

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR changes newly inserted text to use normal filter composition with a transparent background while retaining the solid fallback for saved text that omits background opacity.

  • Changes new text defaults to filter composition and zero background opacity.
  • Preserves explicit saved blend, mask, and opacity settings during hydration and export.
  • Adds editor/runtime pixel checks, save-and-reopen coverage, and documentation updates.
  • Updates the V3 roadmap with revised mask, displaced-ring, and Blob Tracking priorities.

Reviews (1) · Last reviewed commit: "feat: insert text over transparent backg..."

…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
@git-chad
git-chad force-pushed the git-chad/v3-editor-groups branch from f11ac2e to 8f540ba Compare October 1, 2026 07:04
@git-chad
git-chad force-pushed the git-chad/v3-transparent-text branch from 63948d7 to c358bb5 Compare October 1, 2026 07:04
@git-chad
git-chad changed the base branch from git-chad/v3-editor-groups to git-chad/shader-lab-v3-plan October 1, 2026 15:12
@git-chad
git-chad merged commit c358bb5 into git-chad/shader-lab-v3-plan Oct 1, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — c358bb54 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant