Repository navigation
V3: add editor groups, persistence, and runtime export - #155
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
|
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
git-chad
force-pushed
the
git-chad/v3-editor-groups
branch
from
October 1, 2026 07:04
f11ac2e to
8f540ba
Compare
git-chad
changed the base branch from
git-chad/v3-isolated-group-rendering
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Designers can now organize layers into isolated groups in the editor and keep those groups when saving, reopening, undoing changes, or exporting a runtime config. An effect inside a group affects that group's children; group opacity, blend, and visibility apply to the composed result.
Stacked on #154 (
git-chad/v3-isolated-group-rendering), within the V3 integration stack #150. Do not merge to main until the roadmap is complete.Changes
ShaderLabConfig. Older flat projects/configs remain supported. Enforce unique IDs, valid parents, and eight nesting levels before editor hydration.Validation
bun run check— passed (two existing source lint warnings; one warning in a gitignored local fixture script).bun run test:composition— passed: frozen legacy fixtures, 136 blend/mask samples, 34 media-bound samples, 100 alpha samples, 52 group checks, plus the new editor-group integration suite.applyLabProjectFile, malformed-hierarchy rejection without mutation, animation/audio duplication and cleanup, runtime config rendering, and saved/reopened preview/PNG pixel equality. Baselines were not regenerated.Manual review
Follow the group checklist: group a photo and effect over a separate background, adjust group opacity/blend, move and duplicate it, undo changes, then save/reopen and compare PNG export. Confirm desktop and mobile controls before continuing to masks.
Coverage masks and transparent scene/export backgrounds are separate slices. New version-7 saves require this V3 build to reopen. Ungroup removes the group's opacity/blend/visibility contribution, so appearance can change.