Skip to content

fix(githubapp): continue reconcile past a default-branch 404 - #120

Merged
balcsida merged 1 commit into
mainfrom
fix/reconcile-default-branch-404
Sep 26, 2026
Merged

balcsida merged 1 commit into
mainfrom
fix/reconcile-default-branch-404

Conversation

@balcsida

Copy link
Copy Markdown
Owner

Re-lands #103 by @team-humaki as a signed commit (the main ruleset requires signed commits; the original commit was unsigned). Authorship is preserved.

Closes #103
Fixes #102

What

Reconciler.All returned on the first DefaultBranchSHA error, so a renamed or deleted default branch skipped every later installation for the rest of the tick.

  • Keep reconciling the rest of the installation and the remaining installations.
  • Mark the failed repository with error_code=default_branch (cleared on the next successful read) and do not enqueue an empty SHA.
  • Log the installation ID, owner/name, and HTTP status from the periodic refresh and webhook reconcile paths.

Schema / config / security

No migration: repositories.error_code is an unconstrained varchar(128). No config or security changes.

Verification

GOWORK=off go test -race -count=1 ./internal/githubapp/... ./cmd/graphnest-server/
make integration helm-test

Original PR CI (verify, integration, e2e, helm) passed.

🤖 Generated with Claude Code

Closes #103
Fixes #102

Co-Authored-By: Dávid Balatoni <balcsida@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@balcsida
balcsida merged commit 6c3049c into main Sep 26, 2026
12 checks passed
@balcsida
balcsida deleted the fix/reconcile-default-branch-404 branch September 26, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconcile aborts all remaining installations on a single default-branch 404

2 participants