reconcile: continue past a default-branch 404 - #103
Closed
team-humaki wants to merge 2 commits into
Closed
team-humaki wants to merge 2 commits into
team-humaki wants to merge 2 commits into
Conversation
Fixes balcsida#102. A renamed or deleted default branch aborted Reconciler.All, so later installations never refreshed. Mark the repository, keep going, and log installation, owner/name, and HTTP status.
balcsida
self-requested a review
September 19, 2026 10:36
balcsida
approved these changes
Sep 26, 2026
balcsida
left a comment
balcsida
left a comment
Owner
There was a problem hiding this comment.
Reviewed; unit, race, integration and Helm checks pass locally and in CI. Thanks!
Owner
|
Thanks @team-humaki! This landed via #120: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102.
Reconciler.Allreturned on the firstDefaultBranchSHAerror, so a renamed or deleted default branch skipped every later installation for the rest of the tick.error_code=default_branchand do not enqueue an empty SHA.owner/name, and HTTP status from the periodic refresh and webhook reconcile paths.go test ./internal/githubapp/ ./cmd/graphnest-server/passed.