Skip to content

refactor: remove dead code and the isomorphic-git dependency #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehnoorsiddiqui merged 5 commits into from
Oct 19, 2026
Merged

refactor: remove dead code and the isomorphic-git dependency #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5329bb
refactor: drop BuildConfig's write-back code and stale build-file tes…
mehnoorsiddiqui Oct 6, 2026
79765a9
refactor: remove code nothing calls, and the isomorphic-git dependency
mehnoorsiddiqui Oct 6, 2026
0275fab
Merge branch 'dev' into chore/drop-dead-code
mehnoorsiddiqui Oct 12, 2026
b2710cc
remove unused code
mehnoorsiddiqui Oct 12, 2026
16ac1a5
refactor: remove the dead code review found, and test the upload agai…
mehnoorsiddiqui Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ai/skills/value-object.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ These patterns exist in the current codebase and are flagged for awareness:
|---|---|
| Ideal simple wrapper — private field, `static create()`, `toString()` only | `src/types/file/urlPath.ts` |
| `static createInput()` fallback, rich join/equality methods | `src/types/file/directoryPath.ts` |
| Rich predicate (`isMarkDown`) and transform (`normalize`) returning rich type | `src/types/file/fileName.ts` |
| Rich predicate (`hasExtension`) and transform (`normalize`) returning rich type | `src/types/file/fileName.ts` |
| Composed value object — holds two rich types, `static create()` splits at boundary | `src/types/file/filePath.ts` |
| Correct boundary unwrapping — all `.toString()` calls at `fs.*` / `path.*` sites | `src/infrastructure/file-service.ts` |
| Context with flagged public getter (display use) | `src/types/sdk-context.ts` |
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"fumadocs-ui": "16.15.17",
"get-port": "^7.1.0",
"is-in-ci": "^2.0.0",
"isomorphic-git": "^1.37.2",
"lucide-react": "1.47.0",
"mustache": "^4.2.0",
"neverthrow": "^8.2.0",
Expand Down
Loading
Loading