[mehnoorsiddiqui]

Removes code that nothing in the CLI calls, mostly left behind when sdk save-changes was retired (#359) and when the portal stopped reading APIMATIC-BUILD.json. Nothing behaves differently.

Review it commit by commit.

1. BuildConfig and the plugin generate tests

• BuildConfig.toJSON(), the [key: string]: unknown index signature and BuildConfig.from() existed so the build file could be written back to disk. The code that wrote it was removed in feat(portal): build the documentation portal locally with Fumadocs #343.
• The plugin generate tests no longer create an empty APIMATIC-BUILD.json, which plugin generation has not needed since fix: stop requiring APIMATIC-BUILD.json for plugin generate #333. The upload test no longer checks that the file was uploaded.

2. Unused code and isomorphic-git

• src/infrastructure/git-service.ts: the whole file. Nothing has imported it since sdk save-changes was retired. Directory.createFromRelativePaths goes with it, because only this file called it.
• isomorphic-git: only git-service.ts used it. The lockfile loses it and the 22 packages only it depended on.
• Methods with no callers in src/ or test/:
  • FileService: fileExistsSync, pollDeleteDirectory, copyToDir
  • LauncherService: isIdeAvailable, openFolderInIdeWithWait, openInEditor, openFile
  • ActionResult: match
  • ServiceError: invalidResponse(), values
  • SdkPublishInteractivePrompts: sdkDirectoryCannotBeSameAsSourceDirectory
  • FileName.isMarkDown, UrlPath.isLocalhost

Knip found the candidates, and each one was checked with grep, because knip also flagged methods that are called.

3. What review found

• More methods with no callers, or only a call to themselves:
  • ActionResult.getValueOr (it came back with the merge from dev)
  • FileService.copyDirectoryExcluding
  • Directory.mapFilesInDirectory, and Directory.isEmpty, which only it called
  • CodegenOption.codeGenerationVersion
• The plugin upload test seeds a spec under src/ and checks it goes up beside apimatic.json, so a test still shows the whole of src/ is sent.
• The "generates without an APIMATIC-BUILD.json" test is dropped: every test now runs without the build file, so it repeated the success path.
• .ai/skills/value-object.md names hasExtension instead of isMarkDown as FileName's predicate.

Left for later PRs:

• Unused packages in package.json: async-mutex, @oclif/test, simple-git, nyc, eslint-plugin-import, eslint-config-prettier, and the @types packages for base-64, treeify, unzipper and prettier. prettier also belongs in devDependencies.
• Code only tests call: PluginConfig.hasNoSourceRepository, ServiceError.getError, PortalArtifacts.none().
• sdk generate still reads generateVersionedPortal from APIMATIC-BUILD.json to tell whether the SDK is versioned. 2.0 dropped versioned projects, so that check can go, in its own PR.

Tests: 1780 passing, 63 pending (after the merge from dev). tsc --noUnusedLocals finds no unused imports left behind.

🤖 Generated with Claude Code

[saeedjamshaid]

The description says versioned builds wait on a decision, but 2.0 dropped versioned projects; could it say so, leaving their removal to its own PR?

Optional, outside this PR's files: CodegenOption.codeGenerationVersion() (src/types/sdk/generate.ts:67) has no callers either.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mehnoorsiddiqui]

@saeedjamshaid Thanks. The description now says 2.0 dropped versioned projects and leaves removing the generateVersionedPortal check to its own PR. CodegenOption.codeGenerationVersion() is removed in 16ac1a5 too.