Skip to content

Remove unnecessary static synchronization in ToolchainMojo #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary static synchronization in ToolchainMojo #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugins.annotations.Component;

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 29 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated
import org.apache.maven.plugins.annotations.LifecyclePhase;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;
Expand All @@ -46,11 +46,9 @@
configurator = "toolchains-requirement-configurator",
threadSafe = true)
public class ToolchainMojo extends AbstractMojo {
private static final Object LOCK = new Object();

/**
*/
@Component

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-8-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated

Check warning on line 51 in src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-8-zulu 3.10.0-rc-1 

org.apache.maven.plugins.annotations.Component in org.apache.maven.plugins.annotations has been deprecated
private ToolchainManagerPrivate toolchainManagerPrivate;

/**
Expand Down Expand Up @@ -144,9 +142,7 @@
getLog().info("Found matching toolchain for type " + type + ": " + tc);

// store matching toolchain to build context
synchronized (LOCK) {
toolchainManagerPrivate.storeToolchainToBuildContext(tc, session);
}
toolchainManagerPrivate.storeToolchainToBuildContext(tc, session);

return true;
}
Expand Down
Loading