Remove unnecessary static synchronization in ToolchainMojo - #180
Open
elharo wants to merge 1 commit into
Open
Conversation
Fixes apache#174 The static LOCK object and synchronized block around toolchainManagerPrivate.storeToolchainToBuildContext() are unnecessary because: 1. The plugin is marked threadSafe=true, meaning Maven may execute it concurrently for different modules/sessions 2. storeToolchainToBuildContext() stores data into the build context, which is already per-session and thread-safe 3. The static lock introduces unnecessary contention: one module's toolchain selection blocks another unrelated module's selection, defeating the purpose of threadSafe=true In multi-module Maven builds where the toolchains plugin runs in multiple modules, the static lock serializes what could otherwise run in parallel, slowing down builds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a global static synchronization point in ToolchainMojo that unnecessarily serialized toolchain selection across modules in multi-module builds, undermining the plugin’s threadSafe = true intent and introducing avoidable contention.
Changes:
- Removed the static
LOCKfield fromToolchainMojo. - Removed the
synchronized (LOCK)block and performsstoreToolchainToBuildContext(tc, session)directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Problem
The static
LOCKobject andsynchronizedblock aroundtoolchainManagerPrivate.storeToolchainToBuildContext()are unnecessary:threadSafe=true, meaning Maven may execute it concurrently for different modules/sessionsstoreToolchainToBuildContext()stores data into the build context, which is already per-session and thread-safethreadSafe=trueImpact
In multi-module Maven builds where the toolchains plugin runs in multiple modules (e.g., via inherited plugin configuration), the static lock serializes what could otherwise run in parallel, slowing down builds.
Fix
Remove the
private static final Object LOCKfield and thesynchronized (LOCK)block around thestoreToolchainToBuildContextcall, since it provides no benefit.