Skip to content

Fix resource leak pattern in DependencyGraphParser.parseLiteral() #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshinii wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −16
Open

Fix resource leak pattern in DependencyGraphParser.parseLiteral() #2018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6692923
Wrap the BufferedReader in try-with-resources so it is closed even if…
joshinii Jul 29, 2026
3442851
Also use try-with-resources in parse(URL) for consistency
joshinii Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions ...-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,9 @@ public DependencyGraphParser() {
* Parse the given graph definition.
*/
public DependencyNode parseLiteral(String dependencyGraph) throws IOException {
BufferedReader reader = new BufferedReader(new StringReader(dependencyGraph));
DependencyNode node = parse(reader);
reader.close();
return node;
try (BufferedReader reader = new BufferedReader(new StringReader(dependencyGraph))) {
return parse(reader);
}
}

/**
Expand Down Expand Up @@ -173,19 +172,9 @@ public List<DependencyNode> parseMultiResource(String resource) throws IOExcepti
* Parse the graph definition read from the given URL.
*/
public DependencyNode parse(URL resource) throws IOException {
BufferedReader reader = null;
try {
reader = new BufferedReader(new InputStreamReader(resource.openStream(), StandardCharsets.UTF_8));
try (BufferedReader reader =
new BufferedReader(new InputStreamReader(resource.openStream(), StandardCharsets.UTF_8))) {
return parse(reader);
} finally {
try {
if (reader != null) {
reader.close();
reader = null;
}
} catch (final IOException e) {
// Suppressed due to an exception already thrown in the try block.
}
}
}

Expand Down