Fix resource leak pattern in DependencyGraphParser.parseLiteral() - #2018
Fix resource leak pattern in DependencyGraphParser.parseLiteral()#2018joshinii wants to merge 2 commits into
Conversation
… parse() throws. StringReader.close() is currently a no-op, but this is to keep the method consistent with the rest of the codebase. Fixes apache#1996
gnodet
left a comment
There was a problem hiding this comment.
Correct and minimal conversion of parseLiteral() to try-with-resources, consistent with the same pattern already applied to parseMultiResource() in commit 16bbda7. The change is trivially safe since the underlying StringReader.close() is a no-op, but it eliminates a latent leak pattern if the reader type ever changes.
One optional follow-up opportunity: the parse(URL resource) method (lines 175-189) still uses the pre-Java-7 try-finally-catch pattern with manual null checks and a swallowed IOException. Unlike parseLiteral(), that method wraps a real InputStreamReader over resource.openStream(), so converting it to try-with-resources would be more meaningful and would complete the consistency cleanup within this file.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
Reviewer follow-up: this method wraps a real InputStreamReader and was still using the old try-finally-catch pattern with a swallowed IOException.
Wrap the BufferedReader in try-with-resources so it is closed even if parse() throws. StringReader.close() is currently a no-op, but this is to keep the method consistent with the rest of the codebase.
Fixes #1996
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.