Skip to content

test(desktop): await Plan turn settlement #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M4n5ter merged 1 commit into from
Aug 26, 2026
+19 −0
Merged

test(desktop): await Plan turn settlement #3836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions apps/desktop/e2e/composer-plus-menu-stability.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,21 @@ async function rejectBridgeLatch(
);
}

// The fake echo can paint before Runtime Host publishes terminal turn ownership.
// Use the catalog's known-empty live set as the barrier before latching its next read.
async function waitForSessionTurnToSettle(
page: import('@playwright/test').Page,
): Promise<void> {
await expect
.poll(async () =>
page.evaluate(async () => {
const sessions = await window.maka.sessions.list();
return sessions[0]?.runningTurnIds ?? null;
}),
)
.toEqual([]);
}

/**
* Toggling Plan from the ＋ menu must not move the menu.
*
Expand Down Expand Up @@ -266,6 +281,7 @@ test('two rapid Plan toggles land on the last requested state', async ({
await composer.fill('alpha-marker');
await composer.press('Enter');
await expect(page.getByText(/Fake backend received: alpha-marker/)).toBeVisible();
await waitForSessionTurnToSettle(page);

await page.getByRole('button', { name: '添加上下文' }).click();
const menu = page.getByRole('menu', { name: '添加上下文' });
Expand Down Expand Up @@ -300,6 +316,7 @@ test('a failed catalog refresh keeps the committed Plan state visible', async ({
await composer.fill('alpha-marker');
await composer.press('Enter');
await expect(page.getByText(/Fake backend received: alpha-marker/)).toBeVisible();
await waitForSessionTurnToSettle(page);

await page.getByRole('button', { name: '添加上下文' }).click();
const menu = page.getByRole('menu', { name: '添加上下文' });
Expand All @@ -322,6 +339,7 @@ test('latest Plan intent still reaches the Host after a catalog refresh fails',
await composer.fill('alpha-marker');
await composer.press('Enter');
await expect(page.getByText(/Fake backend received: alpha-marker/)).toBeVisible();
await waitForSessionTurnToSettle(page);

await page.getByRole('button', { name: '添加上下文' }).click();
const planRow = page.getByRole('menu', { name: '添加上下文' })
Expand Down Expand Up @@ -352,6 +370,7 @@ test('deleting the session while a toggle is pending settles clean', async ({
await composer.fill('alpha-marker');
await composer.press('Enter');
await expect(page.getByText(/Fake backend received: alpha-marker/)).toBeVisible();
await waitForSessionTurnToSettle(page);

await page.getByRole('button', { name: '添加上下文' }).click();
const menu = page.getByRole('menu', { name: '添加上下文' });
Expand Down