test(desktop): await Plan turn settlement - #3836
Conversation
|
@Astro-Han Hosted exact-head test is green, including the complete Desktop e2e suite. This PR keeps the existing catalog-failure assertions and adds only the authoritative runningTurnIds settlement barrier before the latch. Could you please review when available? |
Generated-by: Codex
cf56ebb to
e62c575
Compare
|
Fresh exact-head est is green on �62c5756e after rebasing onto main=8ff9528eb, including the full Desktop e2e suite. #3814 is ready for maintainer review and merge. |
|
@Astro-Han Current exact head �62c5756e is rebased onto main=8ff9528eb. Hosted est run 32918399089 is green, including all Desktop e2e tests. The barrier is test-only and #3814 remains open until this PR merges. |
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
Rebase-only change from cf56ebb; test-only Plan turn settlement still waits for authoritative empty runningTurnIds before latching catalog. Hosted test: SUCCESS (32918399089).
No P0-P3.
简体中文
该头无阻断。Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
Summary
Stabilize the Plan/catalog-refresh Desktop e2e scenarios by waiting for Runtime Host's authoritative terminal turn ownership before latching the next session-catalog read.
runningTurnIdsto be known-empty;Why
The fake backend response can become visible before Runtime Host publishes terminal turn ownership. The tests previously treated that text as a completion barrier, then observed the Plan row enabled briefly before a late running projection disabled it between the assertion and click.
This reproduced on two unrelated #3789 heads:
The new barrier uses the same known-empty
runningTurnIdsauthority already used by the Desktop streaming e2e suite. It runs beforesessions.listis latched, so the latch still owns only the Plan commit's catalog refresh.Verification
npm run lintnpm run format:checknpm run buildnpm run typechecknpx knip --workspace apps/desktopgit diff --checktestpassed in 9m11s, including the complete Desktop e2e suite.Local Windows Electron did not create its first test window, so the focused runtime assertion requires the hosted Linux/xvfb CI lane. The failure occurred before the test body and is not counted as passing evidence.
AI use
Tool and scope: Codex analyzed the two hosted traces, added the test-only settlement barrier, and ran the listed local gates.
Fixes #3814.
Checklist
testpasses on exact heade62c5756eDoes this PR entail a change in behavior?