Skip to content

[CI] Add pre-commit hook to stop ZIP files being committed - #12930

Open
jbampton wants to merge 2 commits into
apache:mainfrom
jbampton:add-zip-pre-commit-hook
Open

[CI] Add pre-commit hook to stop ZIP files being committed#12930
jbampton wants to merge 2 commits into
apache:mainfrom
jbampton:add-zip-pre-commit-hook

Conversation

@jbampton

Copy link
Copy Markdown
Member

Zip files are hard to track and have security implications

https://pre-commit.com/#repos-repo

https://pre-commit.com/#repository-local-hooks

https://pre-commit.com/#fail

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran pre-commit run --all-files

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (ebc5e64) to head (b5ce276).

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #12930       +/-   ##
============================================
+ Coverage     3.41%   19.64%   +16.23%     
- Complexity       0    19785    +19785     
============================================
  Files          487     6368     +5881     
  Lines        41867   574889   +533022     
  Branches      7912    70353    +62441     
============================================
+ Hits          1429   112934   +111505     
- Misses       40238   449684   +409446     
- Partials       200    12271    +12071     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17310

Copilot AI lite review requested due to automatic review settings August 11, 2026 11:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a pre-commit safeguard to prevent accidental commits of .zip artifacts, aligning with the repo’s CI/dev hygiene goals and reducing risk from opaque binary blobs.

Changes:

  • Introduces a local pre-commit hook that fails commits containing .zip files (case-insensitive).
  • Adds a targeted exclusion for the existing test resource core/src/test/resources/vhds/test.vhd.zip.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants