[CI] Add pre-commit hook to stop ZIP files being committed - #12930
[CI] Add pre-commit hook to stop ZIP files being committed#12930jbampton wants to merge 2 commits into
Conversation
Zip files are hard to track and have security implications https://pre-commit.com/#repos-repo https://pre-commit.com/#repository-local-hooks https://pre-commit.com/#fail
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12930 +/- ##
============================================
+ Coverage 3.41% 19.64% +16.23%
- Complexity 0 19785 +19785
============================================
Files 487 6368 +5881
Lines 41867 574889 +533022
Branches 7912 70353 +62441
============================================
+ Hits 1429 112934 +111505
- Misses 40238 449684 +409446
- Partials 200 12271 +12071
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17310 |
There was a problem hiding this comment.
Pull request overview
Adds a pre-commit safeguard to prevent accidental commits of .zip artifacts, aligning with the repo’s CI/dev hygiene goals and reducing risk from opaque binary blobs.
Changes:
- Introduces a local
pre-commithook that fails commits containing.zipfiles (case-insensitive). - Adds a targeted exclusion for the existing test resource
core/src/test/resources/vhds/test.vhd.zip.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Zip files are hard to track and have security implications
https://pre-commit.com/#repos-repo
https://pre-commit.com/#repository-local-hooks
https://pre-commit.com/#fail
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran
pre-commit run --all-filesHow did you try to break this feature and the system with this change?