[CI] Add manual pre-commit hook to validate the dependabot config - #12932
[CI] Add manual pre-commit hook to validate the dependabot config#12932jbampton wants to merge 2 commits into
Conversation
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12932 +/- ##
============================================
+ Coverage 3.41% 19.64% +16.23%
- Complexity 0 19789 +19789
============================================
Files 487 6368 +5881
Lines 41867 574889 +533022
Branches 7912 70353 +62441
============================================
+ Hits 1429 112962 +111533
- Misses 40238 449653 +409415
- Partials 200 12274 +12074
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17309 |
|
@jbampton , I have found dependabot to be generally useless in this repo (works fine in the website repo). Will this improve the updates as well? |
There was a problem hiding this comment.
Pull request overview
Adds a manual pre-commit hook to validate the repository’s Dependabot configuration, helping catch invalid .github/dependabot.yml changes before they’re committed.
Changes:
- Introduces a new local, manual-stage pre-commit hook to validate
.github/dependabot.ymlvia@bugron/validate-dependabot-yaml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| entry: npx @bugron/validate-dependabot-yaml@0.3.3 | ||
| language: system |
There was a problem hiding this comment.
Using language: system with an npx ...@0.3.3 entry makes this hook depend on whatever Node/npm/npx happens to be installed on the developer machine (and may not run at all if npx isn’t available/in PATH). To make the manual hook reproducible and cross-platform, configure it as a language: node hook with additional_dependencies: ['@bugron/validate-dependabot-yaml@0.3.3'] and set entry to the installed CLI (so pre-commit manages the Node environment and caching).
| entry: npx @bugron/validate-dependabot-yaml@0.3.3 | |
| language: system | |
| entry: validate-dependabot-yaml | |
| language: node | |
| additional_dependencies: ['@bugron/validate-dependabot-yaml@0.3.3'] |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.pre-commit-config.yaml:40
- Using
language: systemwithnpxmakes this hook depend on a preinstalled Node/npm toolchain and can also trigger an interactive "Ok to proceed?" prompt on some npm/npx versions when the package is not already cached. This can break manual hook runs (and any CI job that runs manual hooks). Consider makingnpxnon-interactive at minimum, or switching to a managed pre-commit environment.
entry: npx @bugron/validate-dependabot-yaml@0.3.3
language: system
files: ^\.github/dependabot\.yml$
https://www.npmjs.com/package/@bugron/validate-dependabot-yaml
refs #12930
Description
This PR adds another check or test to our pre-commit framework.
refs apache/sedona#2793
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran the manual hooks with pre-commit"
pre-commit run --all-files --hook-stage manualRan the standard pre-commit hooks:
pre-commit run --all-filesHow did you try to break this feature and the system with this change?