Skip to content

fix(rpc): abort in-flight requests when a request pipeline closes — fixes #305 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ImDanXie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rpc): abort in-flight requests when a request pipeline closes — fixes #305 #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...se-rpc-client/src/main/java/org/apache/bifromq/baserpc/client/ManagedRequestPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ public void close() {
super.close();
meter.recordCount(RPCMetric.ReqPipelineCompleteCount);
cancelPreflightTasks(new RequestAbortException("Pipeline has closed"));
// Also abort in-flight requests: super.close() disposes the stream, so their responses
// can never arrive and onStreamError() will not fire afterwards - leaving the futures pending
// hangs direct (non-batched) callers forever and leaks the inflight tasks.
cancelInflightTasks(new RequestAbortException("Pipeline has closed"));
}
}

Expand Down