Conversation
close() only cancelled preflight (unsent) tasks. Once the stream is disposed by super.close(), responses can never arrive and onStreamError() - the only path that calls cancelInflightTasks() - will not fire again, so the futures of already-sent requests never complete. Callers on the direct (non-batched) query/execute path hang forever; the batched path is only saved by Batcher's orTimeout fallback. Pipelines are replaced via old.close() on store->server route changes, so one range migration with a query in flight triggers it. Abort inflight tasks with RequestAbortException, mirroring onStreamError. Fixes apache#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManagedRequestPipeline.close()only cancelspreflightTaskQueue(requests not yet sent). It never touchesinflightTaskQueue(sent, awaiting a response).Root cause
After
super.close()disposes the stream, responses can never arrive, andonStreamError()— the only path that callscancelInflightTasks()— will not fire again. The futures of already-sent requests therefore never complete:query/executepath hang forever;Batcher'sorTimeout(maxBurstLatency)fallback;Pipelines are replaced via
old.close()on store→server route changes, so a single range migration with a query in flight triggers this.Fix
Abort in-flight tasks on close, mirroring
onStreamError:Verification
onStreamErrorcannot fire aftersuper.close(), is in [BUG] ManagedRequestPipeline.close() leaves in-flight request futures pending forever #305).lib/replacement, one node at a time, zero rollbacks); cluster mesh, all 13 live client connections and cross-node delivery verified post-deploy. No non-batched caller hangs observed.Fixes #305