Skip to content

test: re-enable rebuild-symlink and browser-webdriverio E2E tests #34592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 29, 2026
Merged

test: re-enable rebuild-symlink and browser-webdriverio E2E tests #34592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,12 @@ export async function setupBrowserConfiguration(
if (instance.browser === 'chrome' || instance.browser === 'chromium') {
instance.provider = providerFactory({
capabilities: {
'goog:chromeOptions': { binary: executablePath },
'goog:chromeOptions': {
binary: executablePath,
args: executablePath.includes('rules_browsers')
? ['--no-sandbox', '--disable-dev-shm-usage', '--disable-gpu']
: undefined,
},
Comment thread
alan-agius4 marked this conversation as resolved.
Resolved
},
});
}
Expand Down
13 changes: 7 additions & 6 deletions tests/e2e/tests/build/rebuild-symlink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { symlink } from 'node:fs/promises';
import { resolve } from 'node:path';
import { setTimeout } from 'node:timers/promises';
import { appendToFile, expectFileToMatch, writeMultipleFiles } from '../../utils/fs';
import { execAndWaitForOutputToMatch, waitForAnyProcessOutputToMatch } from '../../utils/process';
import { updateJsonFile } from '../../utils/project';
Expand All @@ -10,11 +11,6 @@ const buildReadyRegEx = getGlobalVariable('argv')['esbuild']
: /Build at: /;

export default async function () {
// TODO: Disabled pending investigation. Steps work outside of test
if (getGlobalVariable('argv')['esbuild']) {
return;
}

await updateJsonFile('angular.json', (configJson) => {
configJson.projects['test-project'].architect.build.options.preserveSymlinks = true;
});
Expand All @@ -32,10 +28,15 @@ export default async function () {
buildReadyRegEx,
);

await setTimeout(200);

// Trigger a rebuild
await Promise.all([
waitForAnyProcessOutputToMatch(buildReadyRegEx),
appendToFile('src/link-source.ts', `\nconsole.log('foo-bar');`),
]);
await expectFileToMatch('dist/test-project/browser/main.js', `console.log('foo-bar')`);

await setTimeout(200);

await expectFileToMatch('dist/test-project/browser/main.js', /console\.log\(["']foo-bar["']\);/);
}
3 changes: 0 additions & 3 deletions tests/e2e/tests/vitest/browser-webdriverio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import { writeFile } from '../../utils/fs';
import { updateJsonFile } from '../../utils/project';

export default async function (): Promise<void> {
// TODO: investigate why this test hangs in CI but works locally.
return;

await applyVitestBuilder({
webdriver: true,
});
Expand Down
Loading