Repository navigation
test: re-enable rebuild-symlink and browser-webdriverio E2E tests - #34592
Merged
alan-agius4 merged 1 commit intoOct 29, 2026
Merged
alan-agius4 merged 1 commit into
alan-agius4 merged 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request re-enables previously disabled end-to-end tests for rebuild symlinks and Vitest browser webdriverio, and configures Chrome options for Vitest with --no-sandbox and --disable-dev-shm-usage. Feedback highlights a security concern with unconditionally disabling the Chrome sandbox, suggesting it only be applied in CI environments. Additionally, the use of a hardcoded setTimeout delay in the rebuild symlink test is flagged as a potential source of flakiness, with recommendations to document the delay or use a more robust synchronization mechanism.
alan-agius4
force-pushed
the
test/e2e-webdriverio-and-rebuild-symlink
branch
from
October 29, 2026 15:23
fa74f52 to
87bed2a
Compare
alan-agius4
added
action: review
clydin
approved these changes
Oct 29, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables the
rebuild-symlinkandbrowser-webdriverioE2E tests and passes--no-sandboxand--disable-dev-shm-usageto Chrome whenCHROME_BINis configured for WebdriverIO.