Skip to content

fix(web): drop count sort order from grouped result links #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andykais merged 1 commit into from
Oct 13, 2026
Merged

fix(web): drop count sort order from grouped result links #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/web/src/lib/runes/media_view_rune.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,10 @@ export class MediaGroupRune extends MediaViewRune {
: []
const tag = `${group_by.tag_group}:${media_response.group.value}`
merged_search_params.query.tags.push(tag)
// 'count' sorting only exists on group_by searches, so fall back to the default media search sort
if (merged_search_params.sort_by === 'count') {
merged_search_params.sort_by = 'created_at'
delete merged_search_params.sort_by
delete merged_search_params.order
}
merged_search_params.limit = 1 // TODO until we implement a filmstrip render, we only need one image
} else {
Expand Down
4 changes: 3 additions & 1 deletion packages/web/src/routes/browse/runes/queryparams.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,11 @@ export class QueryParamsManager extends Rune {
// Clear group_by only params if switching away from group_by mode
if (val !== 'group_by') {
params.group_by = undefined
// 'count' sorting only exists on group_by searches, core rejects it elsewhere
// 'count' sorting only exists on group_by searches, core rejects it elsewhere.
// The order was chosen for the count sort, so drop it along with the sort
if (params.sort === 'count') {
params.sort = DEFAULTS.sort
params.order = DEFAULTS.order
}
}
} else {
Expand Down
Loading