Repository navigation
fix(web): drop count sort order from grouped result links - #92
Merged
Merged
Conversation
Co-authored-by: kaisea.rpi <kaisea.rpi@gmail.com>
andykais
approved these changes
Oct 13, 2026
andykais
marked this pull request as ready for review
October 13, 2026 21:34
Owner
|
This may be a duplicate of 2ad88f1, and I was testing on an older version, but its still a reasonable change. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/browse: when grouping is sorted bycount, the link to the plain media search now dropsorderalong withsort, so it opens with no explicit sort (e.g.?tags=artist:bobinstead of?tags=artist:bob&order=asc)count, the preview's media search no longer hardcodescreated_atand uses core's default sort, matching the page the link openssort=view_count&order=ascstill carries through to the link)Vision Testing
artist:alice(3),artist:bob(2) andartist:carol(1), then ranforager gui/browse?group_by=artist&sort=count&order=asc: the bob link is?tags=artist:boband opens 2 results sorted by Created At (desc)/browse?group_by=artist&sort=count: the alice link is?tags=artist:aliceand opens 3 results/browse?group_by=artist&sort=view_count&order=asc: the alice link keepssort=view_count&order=ascdeno task --cwd packages/web build:localsucceedsgroup-count-sort-links.mp4
To show artifacts inline, enable in settings.