chore: stop building packages during install - #236
Open
lilienblum wants to merge 6 commits into
Open
Conversation
Greptile SummaryRemoves install-time TypeScript compilation and makes required builds explicit.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| turbo.json | Makes tests explicitly build their package and upstream workspace dependencies. |
| packages/bindings/turbo.json | Ensures bindings tests explicitly build the native addon while leaving addon builds uncached. |
| .github/workflows/ci-fast.yml | Replaces the removed install lifecycle side effect with explicit dependency builds before Rust tests. |
| .github/workflows/release.yml | Explicitly builds core and bindings before the staged-addon smoke test. |
| packages/core/package.json | Removes automatic compilation during dependency installation while preserving the explicit build command. |
| packages/commands/package.json | Removes automatic compilation during dependency installation while preserving the explicit build command. |
| packages/bindings/package.json | Removes automatic compilation during dependency installation while preserving explicit TypeScript and addon builds. |
| packages/sdk/package.json | Removes automatic compilation during dependency installation while preserving the explicit build command. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Install["pnpm install"] --> Dependencies["Install dependencies only"]
Build["Explicit pnpm/turbo build"] --> Packages["Compile TypeScript packages"]
Test["turbo test"] --> Build
BindingsTest["bindings test"] --> Addon["build:addon"]
RustCI["Rust fast tests"] --> SelectedBuild["Build SDK and commands dependencies"]
ReleaseSmoke["Addon smoke test"] --> CoreBindings["Build core and bindings"]
Reviews (4): Last reviewed commit: "ci: build SDK dependencies before Rust t..." | Re-trigger Greptile
lilienblum
force-pushed
the
lilienblum/alien-374-stop-building-packages-during-install
branch
from
July 27, 2026 14:54
5495379 to
2bbde8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preparebuild hook from the core, commands, bindings, and SDK packagesbuildcommandsWhy
A workspace
pnpm installcurrently compiles all four packages as a lifecycle side effect. Bootstrap only needs dependencies installed, so that work is unnecessary and makes setup appear stuck.The stable and dev npm release workflows already run
pnpm buildbefore publishing or packing. Aprepackreplacement would keep compilation implicit and duplicate those release build steps.Validation
pnpm install --frozen-lockfilecomplete without invoking the package buildsLinear: ALIEN-374